Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ClassColor names less than 3 characters #798

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eTzmNcbkrng
Copy link

I've noticed a growing trend of people creating characters with names only two characters long.
This commit prevents words like he, it, to, my, no, etc. being coloured as the class of the player that used them.

@Apollyonn
Copy link
Contributor

I don't think thats necessary because you can already exclude names that you don't want to be colored in the elvui setrtings.
WoWScrnShot_061321_133443

@eTzmNcbkrng
Copy link
Author

Yeah I saw that, I was constantly adding players to it though.

@Barsoomx
Copy link

Yeah super annoying, would love to see that merged

@Apollyonn
Copy link
Contributor

In order to accept this, you have to change it a bit and add the ability to completly disable it. For example add a slider to chat settings and modify the code to look something like this. If the slider is set to 0 it will be disabled. I think this is the most ideal way

if wordMatch and (E.global.chat.classColorMentionLetterThreshold > 0 and strlen(lowerCaseWord) >= E.global.chat.classColorMentionLetterThreshold) and not E.global.chat.classColorMentionExcludedNames[wordMatch] then local classColorTable = CUSTOM_CLASS_COLORS and CUSTOM_CLASS_COLORS[classMatch] or RAID_CLASS_COLORS[classMatch] end

@eTzmNcbkrng
Copy link
Author

image

@eTzmNcbkrng
Copy link
Author

In order to accept this, you have to change it a bit and add the ability to completly disable it.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants