[hf-multimodal] pass kwargs to self.processor #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
reviewed
Feb 3, 2025
| @@ -63,6 +65,11 @@ def __init__( | |||
| self.interleave = interleave | |||
| self.max_images = max_images | |||
| self.rgb = convert_img_format | |||
| self.pixels = ( | |||
| {"min_pixels": min_pixels, "max_pixels": max_pixels} | |||
| if min_pixels or max_pixels | |||
There was a problem hiding this comment.
The other will be set to None. Would that still work?
There was a problem hiding this comment.
it's probably best to set them independently . if None then don't add the param , so they lookup a default value: https://github.com/QwenLM/Qwen2.5-VL/blob/7da8b4265d9cd239c7934a89cb5427cba6acbdca/qwen-vl-utils/src/qwen_vl_utils/vision_process.py#L129
nikg4
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just passes
min_pixels,max_pixelsfor now, but on a more general note need a better way to pass specific kwargs from the evaluator fn to the model methods.closes #2666