Add/modify variable names related to surface height/pressure #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svahl991
requested review from
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mattldawson,
mkavulich,
mwaxmonsky,
nusbaume,
peverwhee,
MayeulDestouches and
ss421
as code owners
climbfuji
approved these changes
Sep 24, 2024
nusbaume
requested changes
Sep 24, 2024
nusbaume
approved these changes
Sep 24, 2024
cacraigucar
approved these changes
Sep 24, 2024
ss421
approved these changes
Sep 24, 2024
|
@mkavulich @dustinswales this is ready for your final review and merging - thanks! |
dustinswales
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two names relating to height at surface, and modifies
surface_air_pressurefor the naming rule change coming in #72.(I realize that there is more renaming of existing variables to be done as a product of #72, so I can remove
surface_air_pressurefrom this PR if people feel it is better to do that rename in a group with the others. It's just that this name is of particular interest to the fast-approaching JEDI renaming code sprint, so I wanted to be sure to get it in.)