Add four wind CF variables #73
Conversation
|
Tagging @ncrossette @shlyaeva |
standard_names.xml
Outdated
| long_name="The curl of the vector wind field"> | ||
| <type kind="kind_phys" units="s-1">real</type> | ||
| </standard_name> | ||
| <standard_name name="horizontal_divergence_of_wind" |
There was a problem hiding this comment.
Isn't the CF name divergence_of_wind because CF considers "wind" to be the horizontal component?
There was a problem hiding this comment.
The note attached to divergence of wind (visible if you click on the name) in the CF website says:
"[horizontal_]divergence_of_X" means [horizontal] divergence of a vector X; if X does not have a vertical component then "horizontal" should be omitted. Wind is defined as a two-dimensional (horizontal) air velocity vector, with no vertical component. (Vertical motion in the atmosphere has the standard name upward_air_velocity.)
So now that I read that note more carefully, I see you are correct. Thanks for catching this. I think I misread the note originally. I will make this change.
Tagging @MarekWlasak to make sure he is OK with this change, since he suggested the name with horizontal_ to me originally.
There was a problem hiding this comment.
PR has now been updated to remove horizontal_ from divergence_of_wind.
There was a problem hiding this comment.
.... but wind does have 3 components (u,v w), so we do need the horizontal_ bit otherwise we are talking about the 3 dimensional divergence!
There was a problem hiding this comment.
.... but wind does have 3 components (u,v w), so we do need the
horizontal_bit otherwise we are talking about the 3 dimensional divergence!
I believe what the CF standard is saying in their comment is that wind is defined to be a 2-D variable, with the vertical component broken out as a separate variable (upward_air_velocity), and that's why the horizontal_ prefix is not required in the divergence_of_wind name.
There was a problem hiding this comment.
Ok. Just checked the CF standard. The wind tag is indeed defined as implicitly horizontal, so no need for the prefix. I am bit surprised by this though, as there is no tag for a 3D wind!
Update CODEOWNERS. See in the file itself: "Order is important. The last matching pattern has the most precedence." See #73 for example.
Update CODEOWNERS. See in the file itself: "Order is important. The last matching pattern has the most precedence." See #73 for example.
|
My concerns and suggestions are in #77 |
This adds four variables related to wind fluid dynamics. The names are already CF names that have not yet been added to the CCPP standard.