added option to allow openPMD-api directly from AMReX I/O #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(AMREX_USE_OPENPMD_API is on)
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+195
to
+204
| /* | ||
| using SrcData = WarpXParticleContainer::ParticleTileType::ConstParticleTileDataType; | ||
| tmp.copyParticles(*pc, | ||
| [=] AMREX_GPU_HOST_DEVICE (const SrcData& src, int ip, const amrex::RandomEngine& engine) | ||
| { | ||
| const SuperParticleType& p = src.getSuperParticle(ip); | ||
| return random_filter(p, engine) * uniform_filter(p, engine) | ||
| * parser_filter(p, engine) * geometry_filter(p, engine); | ||
| }, true); | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
Comment on lines
+162
to
+174
| /* should be covered by amrex-openpmd-io | ||
| // SoA: Real | ||
| { | ||
| std::vector<std::string> real_soa_names(RealSoA::names_s.size()); | ||
| std::copy(RealSoA::names_s.begin(), RealSoA::names_s.end(), real_soa_names.begin()); | ||
| for (auto real_idx = 0; real_idx < RealSoA::nattribs; real_idx++) { | ||
| auto const component_name = real_soa_names.at(real_idx); | ||
| getComponentRecord(component_name).resetDataset(d_fl); | ||
| } | ||
| } | ||
| // SoA: Int | ||
| static_assert(IntSoA::nattribs == 0); // not yet used | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
ax3l
reviewed
Feb 21, 2024
| @@ -73,6 +73,8 @@ macro(find_ablastr) | |||
|
|
|||
| # shared libs, i.e. for Python bindings, need relocatable code | |||
| if(ImpactX_PYTHON OR BUILD_SHARED_LIBS) | |||
| set(AMReX_TINY_PROFILE ON CACHE BOOL "") | |||
| set(AMReX_OPENPMD_API ON CACHE BOOL "") | |||
There was a problem hiding this comment.
We have our own variable for this:
Suggested change
| set(AMReX_OPENPMD_API ON CACHE BOOL "") | |
| set(AMReX_OPENPMD ${ImpactX_OPENPMD} CACHE BOOL "" FORCE) |
Comment on lines
+271
to
+277
| } else if (element_type == "beam_plotplus") { | ||
| #ifdef AMREX_USE_OPENPMD_API | ||
| std::string openpmd_name = element_name; | ||
| pp_element.queryAdd("name", openpmd_name); | ||
| std::string openpmd_backend = "default"; | ||
| pp_element.queryAdd("backend", openpmd_backend); | ||
| std::string openpmd_encoding{"g"}; |
There was a problem hiding this comment.
Let's simply update beam_monitor and let us not add another element.
| @@ -36,6 +36,7 @@ | |||
| #include "SoftQuad.H" | |||
| #include "ThinDipole.H" | |||
| #include "diagnostics/openPMD.H" | |||
| #include "diagnostics/plotplus.H" | |||
There was a problem hiding this comment.
Suggested change
| #include "diagnostics/plotplus.H" |
Comment on lines
+56
to
+58
| #ifdef AMREX_USE_OPENPMD_API | ||
| diagnostics::BeamPlotplus, | ||
| #endif |
There was a problem hiding this comment.
Let's update diagnostics::BeamMonitor instead
Suggested change
| #ifdef AMREX_USE_OPENPMD_API | |
| diagnostics::BeamPlotplus, | |
| #endif |
| @@ -1,4 +1,5 @@ | |||
| target_sources(lib | |||
| PRIVATE | |||
| openPMD.cpp | |||
| plotplus.cpp | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to be merged after AMReX openPMD-api I/O is approved: AMReX-Codes/amrex#3666