Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(process): 增加ProcessGroup以及Session机制 #1115

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Feat(process): 增加ProcessGroup以及Session机制 #1115

wants to merge 24 commits into from

Conversation

sparkzky
Copy link
Contributor

在系统中添加进程组以及会话机制，已经过测试

目前tty以及系统的其他部分尚未加入进程组机制，将在接下来继续完成对tty的改造以及在系统中的其他部分中补充进程组的实现

@github-actions github-actions bot added the ambiguous The title of PR/issue doesn't match the format label Mar 25, 2025
@sparkzky sparkzky changed the title Feat(Processgroup) Feat(processgroup) Mar 25, 2025
@sparkzky sparkzky changed the title Feat(processgroup) Feat(process): 增加ProcessGroup以及Session机制 Mar 25, 2025
@github-actions github-actions bot added the enhancement New feature or request label Mar 25, 2025
@sparkzky
Copy link
Contributor Author

image

目前想要在copy_group中修改进程的basic信息，但是到了修改sid的时候就发生调度，而且由于此时进程持有锁的数量不为0，导致panic

@sparkzky
Copy link
Contributor Author

r? @fslongjin

@fslongjin
Copy link
Member

fslongjin commented Mar 27, 2025 •
edited
Loading

image

目前想要在copy_group中修改进程的basic信息，但是到了修改sid的时候就发生调度，而且由于此时进程持有锁的数量不为0，导致panic

为啥要在这里面手动调用schedule

@sparkzky
Copy link
Contributor Author

image
目前想要在copy_group中修改进程的basic信息，但是到了修改sid的时候就发生调度，而且由于此时进程持有锁的数量不为0，导致panic

为啥要在这里面手动调用schedule

image
我没有手动调用schedule，不知道为什么一调用这个方法就触发了调度

fslongjin
fslongjin requested changes Mar 29, 2025
View reviewed changes
Copy link
Member

@fslongjin fslongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以补充个测试报告吗？比如退出的时候如何确认进程组、session已经删除了，以及进行了必要的资源释放的操作？

我貌似没找到释放资源的地方？

@sparkzky
Copy link
Contributor Author

sparkzky commented Apr 1, 2025 •
edited
Loading

test_session

img_v3_02ku_fa012da7-e1ac-41ef-9b2d-233ab511fefg

test-processgroup

img_v3_02ku_9ca98edb-b319-4f6d-adb1-2eb2d2c257ag

目前除了tty的行为不太一致，其他的都是正常的

@sparkzky sparkzky requested a review from fslongjin April 2, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fslongjin fslongjin Awaiting requested review from fslongjin

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ambiguous The title of PR/issue doesn't match the format enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparkzky @fslongjin