Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual studio code for code editor #1774

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

shinecoding
Copy link
Contributor

Changes in this pull request:

  • Add visual studio code for code editor

@das-g
Copy link
Member

das-g commented Oct 5, 2022

Hi @shinecoding

Thanks for this translation. We manage translations of the Django Girls tutorial on Crowdin and already have a translation for this subsection there. Can you check it and either update yours here or the one on Crowdin, so they are the same?

We'd usually sync the Crowdin content of a language to GitHub (from where it'll be deployed to https://tutorial.djangogirls.org) once the translation covers 100% of the original English content. (Syncing earlier would mean to introduce untranslated English sentences into the "translation", which we don't want.) As I somewhat doubt that'll be the case any time soon for the Korean translation, I can offer to merge this PR once its content is in Sync with the subsection translation on Crowdin, so that this translation will be available to users already from then on.

@das-g
Copy link
Member

das-g commented Oct 5, 2022

(Please comment here once you've brought the translations in this pull request (PR) and on Crowdin in sync.)

@das-g das-g requested a review from a team October 5, 2022 08:33
@shinecoding shinecoding closed this Oct 6, 2022
@das-g das-g mentioned this pull request Oct 6, 2022
@das-g
Copy link
Member

das-g commented Oct 6, 2022

Re-opening. (Closed #1775 instead.)

@das-g das-g reopened this Oct 6, 2022
@shinecoding
Copy link
Contributor Author

Thanks for letting me know. I checked the link you sent me and sent a pull request for the synced version only for the vs code section. Do you want me to send a pull request for the entire code editor instructions page?
Also, if I want to translate, should I be translating at crowdin instead of sending you pull requests?

@das-g
Copy link
Member

das-g commented Oct 6, 2022

Thanks for letting me know. I checked the link you sent me and sent a pull request for the synced version only for the vs code section.

Thanks! As you've pushed your new commits to the same branch, this pull request here got automatically updated. As there was thus no need to have a separate pull request, I've closed #1775 and re-opened this one (#1774).

Do you want me to send a pull request for the entire code editor instructions page? Also, if I want to translate, should I be translating at crowdin instead of sending you pull requests?

Preferably on Crowdin, as that allows sentence-by-sentence-proofreading (and marking individual sentences as proofread) by other translators. (See also #1755.) If you're willing to work on the translation, that's of course very much appreciated!

@das-g das-g merged commit 385da4e into DjangoGirls:master Oct 6, 2022
@shinecoding
Copy link
Contributor Author

From what the previous Korean python community and djangogirls translator have told me is that no one has done any translation for the past 3 years, so I would like to check if the existing translations done in the Crowdin is correct and push it here if that's ok with you?

@das-g
Copy link
Member

das-g commented Oct 7, 2022

As the English original of the Django Girls tutorial has changed meanwhile, the Korean translation would certainly be out-of-date. However, you don't have to check sentences that Crowdin still displays as already-translated for whether they are up-to-date, as those changed in the original will show up as untranslated. (Even some that actually stayed the same may be shown as untranslated, as Crowdin doesn't always manage to still match them up if another sentence in respective document has changed.) If you yet want to check them for correctness of the translation, feel free to do so.

Preferably though spend your time on translating sentences Crowdin displays as "untranslated". (Often these are sentences that previously had been translated, but were changed in the original since then.) Once the translation for Korean is at 100% on Crowdin, we can export it and update this Git repo accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants