Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url to path at homework & Improve legibility #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change url to path at homework & Improve legibility #130

wants to merge 2 commits into from

Conversation

academey
Copy link

@academey academey commented Aug 30, 2019

Hello,

I changed code like below at your ko/homework/README.md

*url(r'^drafts/$', views.post_draft_list, name='post_draft_list'), *
to
path('drafts/', views.post_draft_list, name='post_draft_list'),

And also improved legibility.

Thanks.

@academey academey changed the title Fix homework typing error & Improve legibility Change url to path at homework & Improve legibility Aug 30, 2019
@das-g
Copy link
Member

das-g commented Aug 30, 2019

👍 We should think about using the more explicit <int:pk> instead of just <pk> in the code in the English version, too.

@das-g
Copy link
Member

das-g commented Aug 30, 2019

As I don't understand corean, I've only reviewed the code change itself. Can someone from @DjangoGirls/ko-pr check whether they happen in the right context?

@academey
Copy link
Author

It doesn't be reviewed for a long time
I just changed orders so it will be okay for right context. Thanks.
@das-g

@das-g
Copy link
Member

das-g commented Sep 24, 2020

Can someone from @DjangoGirls/ko-pr please hava a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants