-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installation for python 3.6 #51
Conversation
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=======================================
Coverage 85.57% 85.57%
=======================================
Files 13 13
Lines 832 832
=======================================
Hits 712 712
Misses 120 120 Continue to review full report at Codecov.
|
If you're doing this I expect you'll need to add 3.6 to the CI runs as well? We test with all the other supported versions. You may not want to/be able to until PR #49 is merged though, as that contains a lot of CI changes from Tom at the moment. |
It looks like I broke some tests, I'll investigate the best way to fix it |
It's actually a problem in aioca with: |
Sounds reasonable, if you add python 3.6 to the |
Given that DiamondLightSource/aioca#19 was merged, this change is easier, though it will have to wait for next release |
aioca 1.3 is now released for Python 3.6 |
Thanks Tom, I added the version constraint for aioca and CI looks happy now |
No description provided.