Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DeprecationWarning from using "+" operator #123

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

AlexanderWells-diamond
Copy link
Collaborator

This used to be an easy way to return a copy of the array. Now we must use the explicit copy function.

Also removing an export for an enum that no longer exists.

This used to be an easy way to return a copy of the array. Now we must
use the explicit copy function.
@AlexanderWells-diamond AlexanderWells-diamond force-pushed the fix_numpy_deprecation_warning branch from 93f796c to 565bca1 Compare March 29, 2023 08:43
@AlexanderWells-diamond AlexanderWells-diamond changed the title Remove DeprecatioNWarning from using "+" operator Remove DeprecationWarning from using "+" operator Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #123 (565bca1) into master (63995ce) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          14       14           
  Lines         981      981           
=======================================
  Hits          855      855           
  Misses        126      126           
Impacted Files Coverage Δ
softioc/device.py 95.60% <100.00%> (ø)
softioc/fields.py 86.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@Araneidae Araneidae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions
Copy link

Unit Test Results

     15 files  ±0       15 suites  ±0   27m 52s ⏱️ -25s
   249 tests ±0     243 ✔️ ±0      6 💤 ±0  0 ±0 
3 735 runs  ±0  3 295 ✔️ ±0  440 💤 ±0  0 ±0 

Results for commit 565bca1. ± Comparison against base commit 63995ce.

@AlexanderWells-diamond AlexanderWells-diamond merged commit 565bca1 into master Mar 29, 2023
@AlexanderWells-diamond AlexanderWells-diamond deleted the fix_numpy_deprecation_warning branch March 29, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants