Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI to automate building of Docker images #500

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
59f0c6b
Added CLI to automate building of Docker images
tieneupin Feb 19, 2025
37a87ce
Fixed comments
tieneupin Feb 19, 2025
334c387
Merged recent changes from 'main' branch
tieneupin Feb 20, 2025
24a683a
Added start of unit test for 'build_images' CLI
tieneupin Feb 25, 2025
45afe7c
Mocked out the results of 'build_images'
tieneupin Feb 25, 2025
18a4e7f
Create Dockerfiles at the location the 'build_image' command expects
tieneupin Feb 25, 2025
d2a0905
Use default source directory for Murfey from pytest reports
tieneupin Feb 25, 2025
d3b33c2
Moved default flag values out as module-wide variables; tried mocking…
tieneupin Feb 28, 2025
c2ac907
Mocked out return value of the subprocesses
tieneupin Feb 28, 2025
db637c8
Mocked return values for the tag, push, and cleanup functions in the …
tieneupin Feb 28, 2025
f42b0f0
Pass images as individual list items in the subprocess command
tieneupin Feb 28, 2025
e182945
Changed default source directory value
tieneupin Feb 28, 2025
d77a357
Typo in variables to check for
tieneupin Feb 28, 2025
42dfc87
Refactored tests to build all generated Docker image URLs and group t…
tieneupin Feb 28, 2025
8d6978d
Checked that 'push_images' and 'cleanup
tieneupin Feb 28, 2025
05aff18
Tried to fix errors with assert calls for 'push_images' and 'cleanup'
tieneupin Feb 28, 2025
8fa7ebf
Fixed incorrect logic to get call count for 'tag_image'
tieneupin Feb 28, 2025
b8b10bd
Passed 'images' in 'push_images' as a positional argument
tieneupin Feb 28, 2025
b9a4801
Call count for 'tag_image' was calculated incorrectly
tieneupin Feb 28, 2025
4e8927f
Tried to fix logic when parsing space-separated tags
tieneupin Feb 28, 2025
336ea0b
Fixed logic when building tags for the mock return value to pass to n…
tieneupin Feb 28, 2025
c69a790
Logic for preparing return value of 'tag_image' was incorrect
tieneupin Feb 28, 2025
5d45b2d
More fixes to test logic for 'tag_image' call count
tieneupin Feb 28, 2025
298f9ce
More fixes to test logic for 'tag_image' call count
tieneupin Feb 28, 2025
6660f2a
Added unit test for the 'build_image' function
tieneupin Feb 28, 2025
3c148e2
Incorrect brackets
tieneupin Feb 28, 2025
a7a51c6
Added unit test for 'tag_image' function
tieneupin Feb 28, 2025
00dea15
Fixed incorrect unpacking of test paramaters
tieneupin Feb 28, 2025
9048529
Added unit test for the 'push_images' function
tieneupin Feb 28, 2025
be2f38e
Accidentally removed a patched function from 'run()' test; fixed inco…
tieneupin Feb 28, 2025
94a7cc9
Added unit test for 'cleanup' function
tieneupin Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tried to fix logic when parsing space-separated tags
tieneupin committed Feb 28, 2025
commit 4e8927f8f8a5dab4481653de9d87b7e736435c04
2 changes: 1 addition & 1 deletion tests/cli/test_build_images.py
Original file line number Diff line number Diff line change
@@ -92,7 +92,7 @@ def test_run(
)
for flag, value in flags:
if isinstance(value, list) and value:
build_cmd.extend([flag, *value])
build_cmd.extend([flag, " ".join(value)])
if isinstance(value, str) and value:
build_cmd.extend([flag, value])
if isinstance(value, bool) and value: