-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] 파일 복제 버그 수정 #484
base: develop
Are you sure you want to change the base?
[Fix] 파일 복제 버그 수정 #484
Conversation
let newBookmarkData = try! newUrl.bookmarkData(options: .minimalBookmark) | ||
dataToEdit.url = newBookmarkData | ||
PDFSharedData.shared.paperInfo?.url = newBookmarkData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PDFSharedData에 바뀐 이름을 반영해 저장할 때 사용할 수 있도록 변경함
guard let document = pdfView.document else { return } | ||
guard let pdfURL = document.documentURL else { | ||
guard let pdfURL = PDFSharedData.shared.paperInfo?.url, let url = try? URL(resolvingBookmarkData: pdfURL, bookmarkDataIsStale: &a) else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdfView에서 url를 받아와 사용을 했었는데 pdfView에서는 바뀐 url을 반영하지 않아 바뀐 URL을 사용할 수 있게 PDFSharedData에서 받아오도록 변경했습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제발.. 이 문제가 원인이길 바라며..
close #483
변경 사항
팀원에게 전달할 사항(Optional)