[Feat] 태그 관리 기능 구현 #482
Open
[Feat] 태그 관리 기능 구현 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooninbeom
commented
Mar 8, 2025
| @@ -209,7 +209,7 @@ final class PaperDataRepositoryImpl: PaperDataRepository { | |||
| } | |||
| } | |||
|
|
|||
| func addTag(to id: UUID, with tag: String) -> Result<VoidResponse, any Error> { | |||
| func addTag(to id: UUID, with tag: String) -> Result<Tag, any Error> { | |||
There was a problem hiding this comment.
UI반영을 위해(추가된 태그 표시) 추가된 태그를 반환하도록 변경했습니다!
mooninbeom
commented
Mar 8, 2025
| @@ -29,7 +29,7 @@ protocol PaperDataRepository: Sendable { | |||
|
|
|||
| // 문서에 태그를 추가합니다 | |||
| @discardableResult | |||
| func addTag(to id: UUID, with tag: String) -> Result<VoidResponse, Error> | |||
| func addTag(to id: UUID, with tag: String) -> Result<Tag, Error> | |||
mooninbeom
commented
Mar 8, 2025
| @@ -103,7 +103,7 @@ extension DefaultHomeSearchUseCase { | |||
| private func fetchPapersByTagName(_ tagName: String) -> [PaperInfo] { | |||
| let response = tagDataRepository.fetchAllTags() | |||
| if case let .success(tags) = response { | |||
| let result = tags.filter { $0.name == tagName } | |||
| let result = tags.filter { $0.name.localizedCaseInsensitiveContains(tagName) } | |||
There was a problem hiding this comment.
이름이 정확해야지 검색이 되는 기존 로직에서 같은 스펠이 들어가 있으면 검색 결과에 포함이 되도록 수정했습니다!
mooninbeom
commented
Mar 8, 2025
Comment on lines
+52
to
+54
| } setTagAction: { | ||
| setTagAction() | ||
| popover.toggle() |
There was a problem hiding this comment.
PaperInfo 셀의 ellipsis 액션에 태그 관리 액션을 추가했습니다
mooninbeom
commented
Mar 8, 2025
| @@ -34,6 +34,7 @@ final class HomeSearchViewModel: ObservableObject, Sendable { | |||
| enum SearchViewStatus: Hashable { | |||
| case normal | |||
| case search(PaperInfo) | |||
| case setTag(PaperInfo) | |||
There was a problem hiding this comment.
태그 관리 뷰의 트리거를 위해 케이스를 추가 했습니다(이름 수정 뷰의 트리거와 동일하게 돌아감)
mooninbeom
commented
Mar 8, 2025
Comment on lines
+224
to
+226
| .onDisappear { | ||
| homeSearchViewModel.searchPapers() | ||
| } |
There was a problem hiding this comment.
수정 결과가 이전 뷰에 반영이 될 수 있게 해당 뷰를 나가면 데이터를 다시 fetch 하도록 바꾸었습니다!
mooninbeom
commented
Mar 8, 2025
Comment on lines
+17
to
+27
| init(name: String) { | ||
| self.tag = nil | ||
| self.name = name | ||
| self.action = {} | ||
| } | ||
|
|
||
| init(tag: Tag, action: @escaping () -> Void) { | ||
| self.tag = tag | ||
| self.name = tag.name | ||
| self.action = action | ||
| } |
There was a problem hiding this comment.
버튼으로 사용하는 경우와 단순히 보여주기 위한 셀로 쓰이는 경우가 나뉘어져 있어
- 뷰로 사용할 경우 name으로 초기화
- 버튼으로 사용할 경우 tag, 클로저로 초기화
이렇게 나누었습니다!
There was a problem hiding this comment.
초기화를 이런 식으로 사용할 수도 있군요,, 굳굳!!!
mooninbeom
commented
Mar 8, 2025
Comment on lines
+136
to
+139
| .onSubmit { | ||
| if let tag = viewModel.onSubmit(paperInfo: paperInfo) { | ||
| self.paperInfo.tags.append(tag) | ||
| } |
There was a problem hiding this comment.
추가된 태그를 현재 뷰의 paperinfo에 반영합니다!
mooninbeom
commented
Mar 8, 2025
| } | ||
| .frame(width: 400, height: 52) | ||
| .onReceive(viewModel.$searchText) { _ in | ||
| viewModel.searchTagButtonTapped() |
There was a problem hiding this comment.
TextField의 텍스트의 변화에 따라 검색이 실행됩니다(0.5초 간격)
mooninbeom
commented
Mar 8, 2025
Comment on lines
+145
to
+159
| public var showingSearchPlaceholder: Bool { | ||
| !isLoading && searchedTags.isEmpty && searchText.isEmpty && recentAddedTags.isEmpty | ||
| } | ||
|
|
||
| public var showingRecentAddedTags: Bool { | ||
| !isLoading && searchedTags.isEmpty && searchText.isEmpty && !recentAddedTags.isEmpty | ||
| } | ||
|
|
||
| public var showingCreateNewTag: Bool { | ||
| !isLoading && searchedTags.isEmpty && !searchText.isEmpty | ||
| } | ||
|
|
||
| public var showingExistingTags: Bool { | ||
| !isLoading && !searchedTags.isEmpty | ||
| } |
There was a problem hiding this comment.
뷰의 분기설정을 위한 프로퍼티입니다!
mooninbeom
commented
Mar 8, 2025
Comment on lines
+27
to
+33
| var lastSearchTags: [String: String] { | ||
| get { | ||
| UserDefaults.standard.dictionary(forKey: UserDefaultsKeys.lastSearchTags) as? [String: String] ?? [:] | ||
| } | ||
| set { | ||
| UserDefaults.standard.set(newValue, forKey: UserDefaultsKeys.lastSearchTags) | ||
| } |
There was a problem hiding this comment.
태그 관리 내에서 최근 추가된 태그 내역을 저장하는 UserDefaults 입니다
Dorii0513
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #481
변경 사항
스크린샷 or 영상 링크
팀원에게 전달할 사항(Optional)