update cli version #27
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ajwootto - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -26,7 +26,7 @@ export async function run() { | |||
| } | |||
|
|
|||
| try { | |||
| await exec('npm', ['install', '-g', '@devcycle/cli@5.10.1']) | |||
| await exec('npm', ['install', '-g', '@devcycle/cli@5.14.5']) | |||
There was a problem hiding this comment.
suggestion (code_refinement): Consider specifying a more flexible version range for @devcycle/cli.
Using a fixed version can lead to issues with maintainability and compatibility with other packages. A version range like '^5.14.5' might be more appropriate to automatically include non-breaking updates.
| await exec('npm', ['install', '-g', '@devcycle/[email protected]']) | |
| await exec('npm', ['install', '-g', '@devcycle/cli@^5.14.5']) |
| @@ -26,7 +26,7 @@ | |||
| } | |||
|
|
|||
| try { | |||
| await exec('npm', ['install', '-g', '@devcycle/cli@5.10.1']) | |||
| await exec('npm', ['install', '-g', '@devcycle/cli@5.14.5']) | |||
There was a problem hiding this comment.
suggestion (testing): Missing test for updated CLI version
The update to the CLI version should be accompanied by a test to verify that the new version installs correctly and integrates with the system as expected. This is crucial to ensure that the update does not introduce any regressions or compatibility issues.
| await exec('npm', ['install', '-g', '@devcycle/[email protected]']) | |
| const cliVersion = '@devcycle/[email protected]'; | |
| await exec('npm', ['install', '-g', cliVersion]); | |
| const verifyInstall = await exec('npm', ['list', '-g', cliVersion]); | |
| if (!verifyInstall.stdout.includes(cliVersion)) { | |
| throw new Error('Installation of ' + cliVersion + ' failed.'); | |
| } |
No description provided.