-
-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't refresh the page when there are unsaved changes! #10761
Comments
We already won't reload-to-update if there's any sheet up: However, if one tab upgrades, they all must reload or the upgrade gets stuck. To fix this we'd need coordination between tabs, which is basically #9733 - something I'd like to do but it's low on the priority list. I'd suggest using prod DIM instead of beta, since prod generally only updates once a week. |
Fair enough, but I think preventing lost changes is more important than upgrading. All you need is a tab refresh anyway, right? Just make it reload after pushing the save button. |
"Just" is doing a lot of heavy lifting there, but if you'd like to volunteer a PR... |
I swear to god, if I lose another build because of these stupid unprompted refreshes, I'm gonna lose it! Please... I beg you to just add a simple onbeforeunload warning! |
DIM Version
Version 8.42.0.3621 (beta), built on 15/10/2024, 23:51:21
Browser Details
Firefox 131.0.2 (64-bit)
OS Details
Windows 11
Describe the bug
I was making a build and I accidentally clicked on another tab that had DIM open, and it refreshed both tabs, discarding my whole build...
I'd like to request 2 changes, one that also helps with my other issue:
Logs
No response
The text was updated successfully, but these errors were encountered: