Don't refresh the page when there are unsaved changes!

[Revadike]

DIM Version

Version 8.42.0.3621 (beta), built on 15/10/2024, 23:51:21

Browser Details

Firefox 131.0.2 (64-bit)

OS Details

Windows 11

Describe the bug

I was making a build and I accidentally clicked on another tab that had DIM open, and it refreshed both tabs, discarding my whole build...
I'd like to request 2 changes, one that also helps with my other issue:

1. Allow in-between saving, without closing the whole build popup. Same thing for save as new.
2. Add a before leave event handler to prevent refreshes when you have unsaved changes.

Logs

No response

[bhollis]

We already won't reload-to-update if there's any sheet up:
https://github.com/DestinyItemManager/DIM/blob/master/src/app/dim-ui/AutoRefresh.tsx#L199-L200

However, if one tab upgrades, they all must reload or the upgrade gets stuck.

To fix this we'd need coordination between tabs, which is basically #9733 - something I'd like to do but it's low on the priority list.

I'd suggest using prod DIM instead of beta, since prod generally only updates once a week.

[Revadike]

Fair enough, but I think preventing lost changes is more important than upgrading. All you need is a tab refresh anyway, right? Just make it reload after pushing the save button.

[bhollis]

"Just" is doing a lot of heavy lifting there, but if you'd like to volunteer a PR...

[Revadike]

I swear to god, if I lose another build because of these stupid unprompted refreshes, I'm gonna lose it!

Please... I beg you to just add a simple onbeforeunload warning!