[Move] Make invalid move lists ReadonlySets and update their contents

[DayKev]

What are the changes the user will see?

More potential moves used by Metronome

• Apple acid
• Armor cannon
• Astral barrage
• Aura wheel
• Behemoth bash
• Behemoth blade
• Blazing Torque
• Body press
• Branch poke
• Breaking swipe
• Chatter
• Chilling water
• Chilly reception
• Clangorous soul
• Collision Course
• Combat torque
• Covet
• Diamond storm
• Doodle
• Double iron bash
• Double shock
• Dragon ascent
• Dragon energy
• Drum beating
• Dynamax cannon
• Electro drift
• Eternabeam
• False surrender
• Fiery wrath
• Fillet away
• Fleur cannon
• Freeze shock
• Freezing glare
• Glacial lance
• Grav apple
• Hyper drill
• Hyperspace fury
• Hyperspace hole
• Ice burn
• Jet punch
• Jungle healing
• Life dew
• Light of ruin
• Make it rain
• Magical torque
• Meteor assault
• Mind blown
• Moongeist beam
• Nature power
• Natures madness
• Noxious torque
• Origin pulse
• Overdrive
• Photon geyser
• Plasma fists
• Population bomb
• Pounce
• Power shift
• Precipice blades
• Pyro ball
• Rage fist
• Raging bull
• Raging fury
• Relic song
• Ruination
• Salt cure
• Secret sword
• Shed tail
• Snap trap
• Snarl
• Snowscape
• Spectral thief
• Spicy extract
• Spirit break
• Steam eruption
• Steel beam
• Strange steam
• Sunsteel strike
• Surging strikes
• Techno blast
• Tera starstorm
• Theif
• Thousand arrows
• Thousand waves
• Thunder cage
• Thunderous kick
• Tidy up
• Trailblaze
• Twin beam
• V create
• Wicked blow
• Wicked torque

More potential moves used by mirror move

• Aromatherapy
• Aurora veil
• Blazing torque
• Combat torque
• Dynamax cannon
• Happy hour
• Heal bell
• Howl
• Jungle healing
• Life dew
• Light screen
• Lucky chant
• Lunar blessing
• Magical torque
• Nature power
• Noxious torque
• Reflect
• Safeguard
• Spikes
• Stealth rock
• Sticky web
• Tailwind
• Toxic spikes

Why am I making these changes?

Change to ReadonlySets from arrays: These lists should not be modified at runtime.
Change to list contents: More fun.

What are the changes from a developer perspective?

• CallMoveAttr.invalidMoves is now ReadonlySet<MoveId> instead of MoveId[].
• Same for invalidCopyCatMoves, invalidMetronomeMoves, invalidMirrorMoves, invalidAssistMoves and invalidSleepTalkMoves.
• Many moves were removed from invalidMetronomeMoves and some from invalidMirrorMoves because we're not Gamefreak.

Checklist

• Otherwise: I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?

[DayKev]

Btw it's best to view the changes with "Hide Whitespace" https://github.com/Despair-Games/poketernity/pull/874/files?diff=unified&w=1

[Tempo-anon]

Is there a list of which moves are now allowed in the PR desc? Also there should probably be a comment above the invalid move lists that explain there's a custom implementation to allow certain moves.;

[PigeonBar]

I just tested it, and unfortunately, freezing a set doesn't seem to work (e.g., calling this.invalidMoves.delete(moveId) still deletes the move). This PR will still be useful for providing type checks, though.

[DayKev]

I just tested it, and unfortunately, freezing a set doesn't seem to work (e.g., calling this.invalidMoves.delete(moveId) still deletes the move). This PR will still be useful for providing type checks, though.

Hm, maybe I have to call Object.freeze on the variable after it's been assigned to. Lemme see.

[DayKev]

No that didn't work either, wtf?

The Object.freeze() static method freezes an object. Freezing an object prevents extensions and makes existing properties non-writable and non-configurable. A frozen object can no longer be changed: new properties cannot be added, existing properties cannot be removed, their enumerability, configurability, writability, or value cannot be changed, and the object's prototype cannot be re-assigned. freeze() returns the same object that was passed in.

Freezing an object is the highest integrity level that JavaScript provides.

• https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze

[DayKev]

Well I tried a bunch of stuff and wasn't able to make it work like I wanted, oh well... there should still technically be a performance benefit (even if it's very negligible lol) and leaving it doesn't break anything.

[DayKev]

Is there a list of which moves are now allowed in the PR desc? Also there should probably be a comment above the invalid move lists that explain there's a custom implementation to allow certain moves.;

@Tempo-anon Well you can just look in the files changed tab and see the list right there so I didn't put one in the PR description (you may need to disable "whitespace changes" via the link I provided above or by checking this checkbox):

[Tempo-anon]

I updated the PR desc to include the full changes. There should still be a comment near the sets (maybe linking to this PR) to indicate that they are custom sets with extra moves allowed