-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P1] Make getAlly() check for player legal Pokemon #858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits, not playtested yet
src/data/abilities/ab-attrs/post-damage-force-switch-ab-attr.ts
Outdated
Show resolved
Hide resolved
src/data/abilities/ab-attrs/post-damage-force-switch-ab-attr.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few questions, otherwise lgtm
What are the changes the user will see?
Fusion flare/bolt will no longer crash the game if the user's ally is not allowed in battle
Why am I making these changes?
Fixes #840
What are the changes from a developer perspective?
Created a new
PlayerPokemon.getAlly()
function that overridesPokemon.getAlly()
and updated usages of it across the code baseScreenshots/Videos
How to test the changes?
Mono fighting challenge with mankey + type:null
Checklist
main
(such as a hotfix), has the game version been updated (npm run update-version:patch
/npm run update version:minor
?beta
as my base branchnpm run test:silent
)npm run test:create
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so:
Localization
tag to this PR?If there are no locale changes: