[Test] Move selectTarget
from gameManager
to moveHelper
#842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
none
Why am I making these changes?
selectTarget
is outdated and is only being used by moxie testWhat are the changes from a developer perspective?
see PR title, added
private
tag to the method to prevent someone from using itadded
public
tag to some methodsScreenshots/Videos
How to test the changes?
npm run test
Checklist
main
(such as a hotfix), has the game version been updated (npm run update-version:patch
/npm run update version:minor
?beta
as my base branchnpm run test:silent
)npm run test:create
) or updated existing tests related to the PR's changes?Are there any localization additions or changes? If so:
Localization
tag to this PR?If there are no locale changes: