Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Move selectTarget from gameManager to moveHelper #842

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

torranx
Copy link
Contributor

@torranx torranx commented Mar 15, 2025

What are the changes the user will see?

none

Why am I making these changes?

selectTarget is outdated and is only being used by moxie test

What are the changes from a developer perspective?

see PR title, added private tag to the method to prevent someone from using it
added public tag to some methods

Screenshots/Videos

How to test the changes?

npm run test

Checklist

  • ⚠️ If this is a PR for main (such as a hotfix), has the game version been updated (npm run update-version:patch / npm run update version:minor?
  • Otherwise: I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run test:create) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (dark and light)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Have I added the Localization tag to this PR?

If there are no locale changes:

  • Have I made sure not to commit any changes to the locale repo on this branch?

@torranx torranx added the Tests Automated tests related label Mar 15, 2025
@torranx torranx changed the title [Test] Move selectTarget from gameManager to moveHelper [Test] Move selectTarget from gameManager to moveHelper Mar 15, 2025
DayKev
DayKev previously approved these changes Mar 15, 2025
@torranx torranx merged commit cc24287 into beta Mar 15, 2025
8 checks passed
@torranx torranx deleted the test/refactor-select-target branch March 15, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Automated tests related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants