Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2] HA Giratina no longer loses HA when going from origin->altered #662

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Tempo-anon
Copy link
Contributor

What are the changes the user will see?

A HA Giratina that goes from altered->origin and then origin->altered will keep its HA

Why am I making these changes?

#589

What are the changes from a developer perspective?

Changed Origin Giratina's HA to LEVITATE instead of NONE

Screenshots/Videos

n/a

How to test the changes?

const overrides = {
  STARTER_SPECIES_OVERRIDE: Species.GIRATINA,
  STARTING_LEVEL_OVERRIDE:1000,
  STARTING_WAVE_OVERRIDE: 196,
  ITEM_REWARD_OVERRIDE: [{name:"FORM_CHANGE_ITEM"}, {name: "RARE_FORM_CHANGE_ITEM"}],
}

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test:silent)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
    • If so, please leave a link to it here:
  • Has the translation team been contacted for proofreading/translation?

@Tempo-anon Tempo-anon added the P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking. label Feb 13, 2025
@CodeTappert CodeTappert merged commit 9c8f511 into beta Feb 14, 2025
8 checks passed
@CodeTappert CodeTappert deleted the issue589 branch February 14, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants