[Bug] Fix Happy Hour's effect disappearing immediately after usage #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Happy Hour's effect no longer disappears immediately after usage, and it will instead remain until the next arena reset.
Why am I making these changes?
A small bug fix for a bug introduced by #170.
What are the changes from a developer perspective?
AddArenaTagAttr
's default turn count is changed from 1 to 0.Screenshots/Videos
Before the changes: Happy Hour's effect disappears immediately, and the player earns $420
20250105.Before.Fix.Happy.Hour.mp4
After the changes: Happy Hour's effect no longer disappears immediately, and the player earns $840
20250105.After.Fix.Happy.Hour.mp4
How to test the changes?
npm run test happy_hour
Checklist
beta
as my base branchnpm run test
)npm run create-test
) or updated existing tests related to the PR's changes?