Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Happy Hour's effect disappearing immediately after usage #180

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

PigeonBar
Copy link
Contributor

@PigeonBar PigeonBar commented Jan 6, 2025

What are the changes the user will see?

Happy Hour's effect no longer disappears immediately after usage, and it will instead remain until the next arena reset.

Why am I making these changes?

A small bug fix for a bug introduced by #170.

What are the changes from a developer perspective?

  • Happy Hour's arena tag now has a starting turn count of 0, which the code interprets as an arena tag that remains indefinitely (until the next arena reset).
  • Similarly, AddArenaTagAttr's default turn count is changed from 1 to 0.
  • Also added a basic test for Happy Hour.

Screenshots/Videos

Before the changes: Happy Hour's effect disappears immediately, and the player earns $420
20250105.Before.Fix.Happy.Hour.mp4
After the changes: Happy Hour's effect no longer disappears immediately, and the player earns $840
20250105.After.Fix.Happy.Hour.mp4

How to test the changes?

npm run test happy_hour

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?

@PigeonBar PigeonBar added Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking. labels Jan 6, 2025
Tempo-anon
Tempo-anon previously approved these changes Jan 6, 2025
torranx
torranx previously approved these changes Jan 6, 2025
Copy link
Contributor

@innerthunder innerthunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the default turnCount in AddArenaTagAttr to 0? I think that on its own should fix the issue.

@PigeonBar PigeonBar dismissed stale reviews from torranx and Tempo-anon via 736d9f9 January 6, 2025 14:39
@innerthunder innerthunder merged commit e01f138 into beta Jan 7, 2025
12 checks passed
@innerthunder innerthunder deleted the fix-happy-hour branch January 7, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move For move implementations/interactions P2 Bug Minor bug. Used for when a move/ability/interaction is incorrect but is not game breaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants