Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in telemetry logs disablement scenario env var #4185

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Feb 25, 2025

Changes

This PR fixes a typo I found while enabling some system-tests about telemetry following the instrumentation telemetry client full revamp in dd-trace-go. Here are the places that mention the env var without a S:

Why this did not fail before ?

No tracer has the only test running in this scenario enabled.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness marked this pull request as ready for review February 25, 2025 10:30
@eliottness eliottness requested a review from a team as a code owner February 25, 2025 10:30
@eliottness eliottness changed the title Typo in telemetry logs disablement env var Typo in telemetry logs disablement scneario env var Feb 25, 2025
@eliottness eliottness changed the title Typo in telemetry logs disablement scneario env var Typo in telemetry logs disablement scenario env var Feb 25, 2025
@eliottness eliottness force-pushed the eliottness/fix-telemetry-logs-env-typo branch from d95584d to 55e4323 Compare February 25, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant