Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dotnet for probe budget tests #4160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tylfin
Copy link
Contributor

@tylfin tylfin commented Feb 20, 2025

Motivation

This pull request includes several changes to enhance the support for probe snapshot budgets and add new functionality to the DebuggerController in the dotnet weblog. The most important changes include the addition of a new endpoint in DebuggerController, updating the method-to-line number mapping, and removing a missing feature decorator for dotnet.

Changes

Enhancements to probe snapshot budgets and debugger functionality:

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3545-dotnet-probe-budget-test branch from 50c7f60 to 9557653 Compare February 24, 2025 14:45
@tylfin tylfin requested a review from cbeauchesne February 24, 2025 20:55
@tylfin tylfin marked this pull request as ready for review February 24, 2025 20:55
@tylfin tylfin requested review from a team as code owners February 24, 2025 20:55
@tylfin tylfin force-pushed the tyler.finethy/DEBUG-3545-dotnet-probe-budget-test branch from 5863178 to 88af692 Compare February 25, 2025 17:12
@tylfin tylfin changed the title add: enable dotnet for probe budget tests Enable dotnet for probe budget tests Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant