Enable dotnet for probe budget tests #4160
Open
+12
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request includes several changes to enhance the support for probe snapshot budgets and add new functionality to the
DebuggerController
in the dotnet weblog. The most important changes include the addition of a new endpoint inDebuggerController
, updating the method-to-line number mapping, and removing a missing feature decorator for dotnet.Changes
Enhancements to probe snapshot budgets and debugger functionality:
utils/build/docker/dotnet/weblog/Controllers/DebuggerController.cs
: Added a new endpointBudgets
that accepts an integer parameterloops
and returns a content response after performing a no-operation loop.tests/debugger/utils.py
: Updated themethod_and_language_to_line_number
method to include the line number for "Budgets" in dotnet.tests/debugger/test_debugger_probe_snapshot.py
: Removed the@missing_feature
decorator for dotnet in thetest_log_line_probe_snaphots_budgets
method, indicating that probe snapshot budgets are now implemented for dotnet.Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present