Skip to content

fix(subprocess): simplify subprocess debug logging messages [backport 2.21] #13189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 14, 2025

Backport 7367467 from #13186 to 2.21.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

---------

Co-authored-by: erikayasuda <[email protected]>
(cherry picked from commit 7367467)
@github-actions github-actions bot requested review from a team as code owners April 14, 2025 15:12
@github-actions github-actions bot requested review from wantsui and nsrip-dd April 14, 2025 15:12
Copy link
Contributor Author

CODEOWNERS have been resolved as:

releasenotes/notes/fix-subprocess-debug-logging-d6eb35359abdbda5.yaml   @DataDog/apm-python
ddtrace/contrib/internal/subprocess/patch.py                            @DataDog/asm-python

@pr-commenter
Copy link

pr-commenter bot commented Apr 14, 2025

Benchmarks

Benchmark execution time: 2025-04-14 15:54:04

Comparing candidate commit b657360 in PR branch backport-13186-to-2.21 with baseline commit 95dc005 in branch 2.21.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 418 metrics, 2 unstable metrics.

@brettlangdon
Copy link
Member

Manually merging since the check_new_flaky_tests job appears to have an issue, but we have confirmed the rest of the pipeline looks good.

@brettlangdon brettlangdon merged commit d30cde0 into 2.21 Apr 15, 2025
707 of 709 checks passed
@brettlangdon brettlangdon deleted the backport-13186-to-2.21 branch April 15, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant