-
Notifications
You must be signed in to change notification settings - Fork 431
chore(iast): improve microbenchmarks accuracy [backport 3.4] #13174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.4
Are you sure you want to change the base?
Conversation
- remove `loops` and `value` config from appsec_iast_aspects/config.yaml and use the default values - split `appsec_iast_aspects` into smaller steps due to the default values returns timeout in the CI - Fix exception in `appsec_iast_propagation/scenario.py` ``` File "/app/benchmarks/.venv_baseline/lib/python3.9/site-packages/pyperf/_runner.py", line 494, in task_func return time_func(loops, *args) File "/app/benchmarks/bm/_scenario.py", line 64, in _pyperf run(loops) File "/app/benchmarks/scenario.py", line 99, in _ launch_function(self.iast_enabled, func, self.internal_loop, caller_loop) File "/app/benchmarks/scenario.py", line 81, in launch_function tainted_value = new_request(enable_propagation) File "/app/benchmarks/scenario.py", line 75, in new_request taint_pyobject_with_ranges(tainted, (CHECK_RANGES[0],)) File "/app/benchmarks/scenario.py", line 41, in taint_pyobject_with_ranges set_ranges(pyobject, tuple(ranges)) ValueError: iast::propagation::native::error::Tainted Map isn't initialized Traceback (most recent call last): ``` - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit b1950af)
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 3 ms. The average import time from base is: 245 ± 3 ms. The import time difference between this PR and base is: -2.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-11 12:20:48 Comparing candidate commit 63763af in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 497 metrics, 2 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathdirname_aspect
scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathnormcase_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
Backport #13160 to 3.4
loops
andvalue
config from appsec_iast_aspects/config.yaml and use the default valuesappsec_iast_aspects
into smaller steps due to the default values returns timeout in the CIappsec_iast_propagation/scenario.py
Checklist
Reviewer Checklist