-
Notifications
You must be signed in to change notification settings - Fork 431
fix(iast): invalid f-string type conversions exception in format_value_aspect [backport 3.4] #13173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.4
Are you sure you want to change the base?
Conversation
…e_aspect (#13156) This fixes a bug with f-strings when IAST is enabled: when building an invalid string that should raise an "Unknown format code X" exception, the error wasn't being triggered in certain cases. like ``` f"{text:05d}" ``` Should raise a ValueError("Unknown format code 'd' for object of type 'str'") ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Munir Abdinur <[email protected]> (cherry picked from commit f807b8e)
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 235 ± 4 ms. The average import time from base is: 235 ± 3 ms. The import time difference between this PR and base is: 0.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-11 14:22:58 Comparing candidate commit 989920d in PR branch Found 0 performance improvements and 7 performance regressions! Performance is the same for 491 metrics, 2 unstable metrics. scenario:iast_aspects-ospathbasename_aspect
scenario:iast_aspects-ospathdirname_aspect
scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathnormcase_aspect
scenario:iast_aspects-ospathsplit_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
scenario:iast_aspects-ospathsplitext_aspect
|
Backport f807b8e from #13156 to 3.4.
This fixes a bug with f-strings when IAST is enabled: when building an invalid string that should raise an "Unknown format code X" exception, the error wasn't being triggered in certain cases. like
Should raise a ValueError("Unknown format code 'd' for object of type 'str'")
Checklist
Reviewer Checklist