OpenTelemetry - fix Span.kind
property to return SpanKind
instead of str
#13159
+485
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the
Span.kind
property from the OpenTelemetry integration is returning a string value instead of aSpanKind
enum. Because of this, the logic for setting the operation name cannot work properlyI propose to merge these changes as they:
Span.kind
property to return theSpanKind
enum as it should, instead of a string valueSpan._datadog_operation_name
property will start to work properly (as it is comparing toSpanKind
enum values). I also fixed the logic for when thenetwork.protocol.name
attribute is setChecklist
Reviewer Checklist