chore(llmobs): better span linking logic for langchain integration #12386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refines the beta span linking logic for llmobs langchain spans to reduce memory
removes the
_spans
mapping of instance IDs to spans. instead, since we really only used this for steps in chains, and the same runnable (e.g. chat model) could be used in different chains, we want to do this mapping by chain instance.when "recording" an instance we trace, we always do the span --> instance mapping. however, now the instance --> span mapping is only done as a temporary property on chains, as steps outside of chains will be defaulted to their parent span for linkage. this also makes cleanup easier, as we can delete the property and let GC take care of getting rid of the mapping that's unreferenced.
MLOB-2245
Checklist
Reviewer Checklist