Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(integrations): remove deprecated internal modules [asyncio,gevent] #12245

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Feb 6, 2025

  • Removes deprecated asyncio modules that are no longer used
  • Removes deprecated gevent modules that are no longer used

All removed code are defined in internal modules and are not exposed in our public api. This is not a breaking change. This change can go out in a minor release.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from emmettbutler February 6, 2025 17:47
@pr-commenter
Copy link

pr-commenter bot commented Feb 6, 2025

Benchmarks

Benchmark execution time: 2025-02-06 22:26:44

Comparing candidate commit 7fda1a7 in PR branch munir/remove-deprecated-integrations with baseline commit 1247ac2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@erikayasuda erikayasuda changed the base branch from 3.x-staging to main February 6, 2025 19:08
@mabdinur mabdinur changed the title chore(integrations): remove internal deprecation warnings [NOT BREAKING] chore(integrations): remove internal deprecation warnings from asyncio and gevent Feb 6, 2025
@mabdinur mabdinur changed the title chore(integrations): remove internal deprecation warnings from asyncio and gevent chore(integrations): remove deprecated internal modules [flask_cache,asyncio,gevent] Feb 6, 2025
@mabdinur mabdinur changed the title chore(integrations): remove deprecated internal modules [flask_cache,asyncio,gevent] chore(integrations): remove deprecated internal modules [asyncio,gevent] Feb 6, 2025
@mabdinur mabdinur force-pushed the munir/remove-deprecated-integrations branch from df6760c to 69f900b Compare February 6, 2025 20:48
@DataDog DataDog deleted a comment from github-actions bot Feb 6, 2025
@mabdinur mabdinur marked this pull request as ready for review February 6, 2025 20:48
@mabdinur mabdinur requested review from a team as code owners February 6, 2025 20:48
Copy link
Contributor

github-actions bot commented Feb 6, 2025

CODEOWNERS have been resolved as:

tests/contrib/asyncio/test_tracer.py                                    @DataDog/apm-core-python @DataDog/apm-idm-python

@mabdinur mabdinur force-pushed the munir/remove-deprecated-integrations branch from 69f900b to ac55696 Compare February 6, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant