Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathan.chavez/debugging dist tracing #12234

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

jjxct
Copy link
Contributor

@jjxct jjxct commented Feb 5, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@jjxct jjxct requested a review from a team as a code owner February 5, 2025 21:51
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CODEOWNERS have been resolved as:

ddtrace/llmobs/_experiments.py                                          @DataDog/ml-observability
tests/llmobs/cassettes/experiments/test_dataset_pull.yaml               @DataDog/ml-observability
tests/llmobs/cassettes/experiments/test_dataset_pull_dne.yaml           @DataDog/ml-observability
tests/llmobs/test_llmobs_experiments.py                                 @DataDog/ml-observability
ddtrace/llmobs/__init__.py                                              @DataDog/ml-observability
ddtrace/llmobs/_constants.py                                            @DataDog/ml-observability
ddtrace/llmobs/_integrations/base.py                                    @DataDog/ml-observability
ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability
ddtrace/llmobs/_utils.py                                                @DataDog/ml-observability
ddtrace/llmobs/_writer.py                                               @DataDog/ml-observability
tests/llmobs/test_utils.py                                              @DataDog/ml-observability

Comment on lines +556 to +557
else:
return projects[0]["id"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Quality Violation

else is not necessary since the if clause has a return (...read more)

If the code in the if branch returns a value, do not have the else branch present.

View in Datadog  Leave us feedback  Documentation

@erikayasuda erikayasuda force-pushed the main branch 2 times, most recently from 1247ac2 to 2ccaaef Compare February 6, 2025 20:43
@pr-commenter
Copy link

pr-commenter bot commented Feb 11, 2025

Benchmarks

Benchmark execution time: 2025-02-11 23:10:50

Comparing candidate commit 9ecc788 in PR branch jonathan.chavez/debugging-dist-tracing with baseline commit 06e8f84 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants