Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce APM_TRACING RC product #11980

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

P403n1x87
Copy link
Contributor

We introduce the APM_TRACING remote configuration product that allows dispatching remote configuration to the library for remote enablement/ configuration of library components and features.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 16, 2025
@P403n1x87 P403n1x87 self-assigned this Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

CODEOWNERS have been resolved as:

ddtrace/internal/remoteconfig/products/__init__.py                      @DataDog/remote-config @DataDog/apm-core-python
ddtrace/internal/remoteconfig/products/apm_tracing.py                   @DataDog/remote-config @DataDog/apm-core-python
ddtrace/debugging/_debugger.py                                          @DataDog/debugger-python
ddtrace/debugging/_products/dynamic_instrumentation.py                  @DataDog/debugger-python
pyproject.toml                                                          @DataDog/python-guild
tests/debugging/mocking.py                                              @DataDog/debugger-python
ddtrace/internal/remoteconfig/products/client.py                        @DataDog/remote-config @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 16, 2025

Datadog Report

Branch report: chore/apm-tracing-rc
Commit report: 7c4ca59
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 50.35s Total duration (35m 10.03s time saved)

@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from 6367ef6 to 13eabbc Compare January 16, 2025 11:33
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2025

Benchmarks

Benchmark execution time: 2025-02-19 15:49:34

Comparing candidate commit 3d93ec6 in PR branch chore/apm-tracing-rc with baseline commit 89689b8 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 416 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathbasename_aspect

  • 🟥 execution_time [+326.159ns; +380.776ns] or [+9.754%; +11.387%]

scenario:iast_aspects-ospathsplit_aspect

  • 🟥 execution_time [+408.004ns; +471.570ns] or [+10.585%; +12.235%]

@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from 13eabbc to 7c4ca59 Compare January 20, 2025 13:52
@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from 7c4ca59 to a793862 Compare January 30, 2025 10:46
@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 30, 2025

Datadog Report

Branch report: chore/apm-tracing-rc
Commit report: 3d93ec6
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1184 Skipped, 1m 48.36s Total Time

@erikayasuda erikayasuda force-pushed the main branch 2 times, most recently from 1247ac2 to 2ccaaef Compare February 6, 2025 20:43
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also record the right capabilities once they set.

@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from a793862 to 5eb55df Compare February 14, 2025 15:42
We introduce the APM_TRACING remote configuration product that allows
dispatching remote configuration to the library for remote enablement/
configuration of library components and features.
@P403n1x87 P403n1x87 force-pushed the chore/apm-tracing-rc branch from 5eb55df to e55bebb Compare February 14, 2025 16:06
@P403n1x87 P403n1x87 marked this pull request as ready for review February 19, 2025 15:05
@P403n1x87 P403n1x87 requested a review from a team as a code owner February 19, 2025 15:05
@P403n1x87 P403n1x87 requested review from a team as code owners February 19, 2025 15:05
@P403n1x87 P403n1x87 requested a review from juanjux February 19, 2025 15:05
@P403n1x87 P403n1x87 enabled auto-merge (squash) February 19, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants