Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track_error: false on ignored caught exceptions #3074

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Feb 6, 2025

Fixes #3047.

@bwoebi bwoebi requested a review from a team as a code owner February 6, 2025 18:10
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.95%. Comparing base (9cc3c1f) to head (e9ceb7b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3074   +/-   ##
=========================================
  Coverage     72.95%   72.95%           
  Complexity     2790     2790           
=========================================
  Files           139      139           
  Lines         15280    15280           
  Branches       1047     1047           
=========================================
  Hits          11147    11147           
  Misses         3580     3580           
  Partials        553      553           
Flag Coverage Δ
appsec-extension 68.28% <ø> (ø)
tracer-php 74.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cc3c1f...e9ceb7b. Read the comment docs.

@bwoebi bwoebi force-pushed the bob/track_no_errors branch from 28b9656 to eb628cc Compare February 7, 2025 14:05
@bwoebi bwoebi force-pushed the bob/track_no_errors branch from eb628cc to e9ceb7b Compare February 7, 2025 14:36
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-02-07 15:04:56

Comparing candidate commit e9ceb7b in PR branch bob/track_no_errors with baseline commit 9cc3c1f in branch master.

Found 6 performance improvements and 1 performance regressions! Performance is the same for 171 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-16.128µs; -7.752µs] or [-8.304%; -3.992%]

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+11.316µs; +18.056µs] or [+6.154%; +9.819%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟩 execution_time [-543.020ns; -251.580ns] or [-7.455%; -3.454%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟩 execution_time [-521.491ns; -257.509ns] or [-7.134%; -3.522%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟩 execution_time [-587.447ns; -223.153ns] or [-8.008%; -3.042%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-506.823ns; -242.977ns] or [-6.921%; -3.318%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟩 execution_time [-1000.000ns; -1000.000ns] or [-50.000%; -50.000%]

@bwoebi bwoebi merged commit 6aa19c7 into master Feb 12, 2025
735 of 756 checks passed
@bwoebi bwoebi deleted the bob/track_no_errors branch February 12, 2025 19:05
@github-actions github-actions bot added this to the 1.7.0 milestone Feb 12, 2025
@realFlowControl realFlowControl modified the milestones: 1.7.0, 1.6.4 Feb 14, 2025
realFlowControl pushed a commit that referenced this pull request Feb 14, 2025
realFlowControl pushed a commit that referenced this pull request Feb 14, 2025
realFlowControl pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Laravel's $dontReport and $internalDontReport are ignored
4 participants