Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.36.0 proposal #5231

Merged
merged 18 commits into from
Feb 10, 2025
Merged

v5.36.0 proposal #5231

merged 18 commits into from
Feb 10, 2025

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Feb 7, 2025

  • [adbba87e82] - (SEMVER-PATCH) Clean up ESLint config (Thomas Watson) #5214
  • [66c13fc934] - (SEMVER-PATCH) [asm] iast taint-tracking flaky (Igor Unanua) #5225
  • [ff4072e9e5] - (SEMVER-PATCH) remove ability to propagate baggage on its own to avoid app crashes (Ida Liu) #5209
  • [2805a22b46] - (SEMVER-PATCH) Fix flaky test in rewriter.spec.js (Ugaitz Urien) #5222
  • [218c35a678] - (SEMVER-PATCH) temporarily skip plugin-mongoose test for 8.10.0 (Igor Unanua) #5219
  • [f49e6ffac3] - (SEMVER-PATCH) Remove legacyStorage in favor of namespaced storages (Brian Marks) #5206
  • [cde936144e] - (SEMVER-MINOR) [test optimization] [SDTEST-1243] Add tag whenever the test service is provided by the user (Juan Antonio Fernández de Alba) #5191
  • [1b7c421171] - (SEMVER-PATCH) ci: unpin datadog actions (Christoph Hamsen) #5199
  • [3b782cd4ec] - (SEMVER-PATCH) simplify storage.js, adding a bunch of comments for clarity (Bryan English) #5203
  • [eec4d2873d] - (SEMVER-MINOR) ESM support for iast (Ugaitz Urien) #5012
  • [c7b0c1831c] - (SEMVER-PATCH) add concurrency group to all-green ci job (Roch Devost) #5196
  • [dd4e11a24f] - (SEMVER-PATCH) update ci nightly schedules to run 3 times (Roch Devost) #5197
  • [15b9f39a82] - (SEMVER-PATCH) add yarnrc with ignore-engines config (Roch Devost) #5183
  • [c403eee48e] - (SEMVER-PATCH) simplify wrap and trace (Bryan English) #5192
  • [5d6e698510] - (SEMVER-PATCH) ci: pin github actions by hash and update via dependabot (Christoph Hamsen) #5193
  • [386f4e7f16] - (SEMVER-PATCH) [test optimization] Fix cy.window for multi origin tests (Juan Antonio Fernández de Alba) #5185
  • [51a58bc172] - (SEMVER-PATCH) [test optimization][SDTEST-1355] Fix ATR + DI (Juan Antonio Fernández de Alba) #5176

juan-fernandez and others added 15 commits February 7, 2025 15:14
* Add dependabot for github actions

* Pin all actions by hash
* Remove orphanable option from wrap and trace. They were deprecated in
  v4, meaning they no longer work in supported versions anyway.
* Remove noop check from wrap. The noop check is for internal use only,
  and we no longer use wrap internally, so it's unneeded in wrap.
* Make DatadogStorage extend from AsyncLocalStorage
* Add comments everywhere
This partially reverts commit 5d6e698.

Co-authored-by: simon-id <[email protected]>
…5209)

* remove ability to propagate baggage on its own to bandage app crash

* modify unit test

* tidy up code

* add clarifying comment

* code fix

* code clean up season 2

* attempted code fix
Copy link

github-actions bot commented Feb 7, 2025

Overall package size

Self size: 8.62 MB
Deduped: 95.03 MB
No deduping: 95.54 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 81.96721% with 33 lines in your changes missing coverage. Please review.

Please upload report for BASE (v5.x@767e601). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/datadog-plugin-mocha/src/index.js 0.00% 13 Missing ⚠️
packages/datadog-plugin-cucumber/src/index.js 0.00% 11 Missing ⚠️
...d-trace/src/appsec/iast/taint-tracking/rewriter.js 92.30% 3 Missing ⚠️
packages/dd-trace/src/appsec/index.js 50.00% 2 Missing ⚠️
packages/dd-trace/src/plugins/plugin.js 75.00% 2 Missing ⚠️
packages/datadog-plugin-mariadb/src/index.js 66.66% 1 Missing ⚠️
...src/ci-visibility/dynamic-instrumentation/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v5.x    #5231   +/-   ##
=======================================
  Coverage        ?   81.16%           
=======================================
  Files           ?      483           
  Lines           ?    21540           
  Branches        ?        0           
=======================================
  Hits            ?    17483           
  Misses          ?     4057           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 7, 2025

Datadog Report

Branch report: v5.36.0-proposal
Commit report: 28b681e
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 626 Passed, 0 Skipped, 11m 30.25s Total Time

iunanua and others added 3 commits February 10, 2025 10:40
Overview over changes:

- Allow the use of Node.js APIs in Node.js v18.0.0 and above
- Remove disabled rules that were too agressive (replace with inline
  ignore comments or fix lint errors)
- Scope mocha rules to only apply to test files
- Use modern style of extending imported flat config files
- Rename `package.json` script `lint-fix` to `lint:fix`
- Delete unused `.rslintrc.json` files
- Name all config groups (useful for debugging)
@rochdev rochdev marked this pull request as ready for review February 10, 2025 15:52
@rochdev rochdev requested a review from a team as a code owner February 10, 2025 15:52
@rochdev rochdev merged commit 31501ea into v5.x Feb 10, 2025
348 of 350 checks passed
@rochdev rochdev deleted the v5.36.0-proposal branch February 10, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants