-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix continuation metrics #8635
Merged
Merged
Fix continuation metrics #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move capture and canceled continuation metrics to the same class (previously we only recorded a canceled continuation metric when pending trace was enabled, not when streaming spans) Fixed finished continuation metric (this was in the wrong place which meant it was only recorded when closing message spans)
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050828
Total [baseline] (8.694 s) : 0, 8694179
Agent [candidate] (1.051 s) : 0, 1050900
Total [candidate] (8.656 s) : 0, 8655531
section iast
Agent [baseline] (1.176 s) : 0, 1176492
Total [baseline] (9.223 s) : 0, 9223342
Agent [candidate] (1.187 s) : 0, 1187045
Total [candidate] (9.271 s) : 0, 9271170
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183449
Total [baseline] (9.276 s) : 0, 9276191
Agent [candidate] (1.198 s) : 0, 1197800
Total [candidate] (9.284 s) : 0, 9283928
section iast_TELEMETRY_OFF
Agent [baseline] (1.183 s) : 0, 1182793
Total [baseline] (9.253 s) : 0, 9253128
Agent [candidate] (1.176 s) : 0, 1175756
Total [candidate] (9.269 s) : 0, 9268641
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.562 ms) : 0, 719562
BytebuddyAgent [candidate] (718.692 ms) : 0, 718692
GlobalTracer [baseline] (238.514 ms) : 0, 238514
GlobalTracer [candidate] (238.811 ms) : 0, 238811
AppSec [baseline] (54.845 ms) : 0, 54845
AppSec [candidate] (54.917 ms) : 0, 54917
Debugger [baseline] (4.431 ms) : 0, 4431
Debugger [candidate] (5.118 ms) : 0, 5118
Remote Config [baseline] (708.322 µs) : 0, 708
Remote Config [candidate] (703.784 µs) : 0, 704
Telemetry [baseline] (13.03 ms) : 0, 13030
Telemetry [candidate] (12.97 ms) : 0, 12970
section iast
BytebuddyAgent [baseline] (835.913 ms) : 0, 835913
BytebuddyAgent [candidate] (844.091 ms) : 0, 844091
GlobalTracer [baseline] (228.673 ms) : 0, 228673
GlobalTracer [candidate] (229.907 ms) : 0, 229907
IAST [baseline] (22.888 ms) : 0, 22888
IAST [candidate] (23.133 ms) : 0, 23133
AppSec [baseline] (55.797 ms) : 0, 55797
AppSec [candidate] (56.524 ms) : 0, 56524
Debugger [baseline] (4.225 ms) : 0, 4225
Debugger [candidate] (4.216 ms) : 0, 4216
Remote Config [baseline] (617.875 µs) : 0, 618
Remote Config [candidate] (609.999 µs) : 0, 610
Telemetry [baseline] (8.841 ms) : 0, 8841
Telemetry [candidate] (8.797 ms) : 0, 8797
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.238 ms) : 0, 841238
BytebuddyAgent [candidate] (852.378 ms) : 0, 852378
GlobalTracer [baseline] (229.643 ms) : 0, 229643
GlobalTracer [candidate] (231.925 ms) : 0, 231925
IAST [baseline] (23.186 ms) : 0, 23186
IAST [candidate] (23.123 ms) : 0, 23123
AppSec [baseline] (56.073 ms) : 0, 56073
AppSec [candidate] (56.583 ms) : 0, 56583
Debugger [baseline] (4.227 ms) : 0, 4227
Debugger [candidate] (4.301 ms) : 0, 4301
Remote Config [baseline] (609.889 µs) : 0, 610
Remote Config [candidate] (619.246 µs) : 0, 619
Telemetry [baseline] (8.751 ms) : 0, 8751
Telemetry [candidate] (9.025 ms) : 0, 9025
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (841.297 ms) : 0, 841297
BytebuddyAgent [candidate] (835.273 ms) : 0, 835273
GlobalTracer [baseline] (229.372 ms) : 0, 229372
GlobalTracer [candidate] (229.396 ms) : 0, 229396
IAST [baseline] (22.613 ms) : 0, 22613
IAST [candidate] (22.285 ms) : 0, 22285
AppSec [baseline] (56.247 ms) : 0, 56247
AppSec [candidate] (55.859 ms) : 0, 55859
Debugger [baseline] (4.195 ms) : 0, 4195
Debugger [candidate] (4.133 ms) : 0, 4133
Remote Config [baseline] (606.804 µs) : 0, 607
Remote Config [candidate] (594.597 µs) : 0, 595
Telemetry [baseline] (8.743 ms) : 0, 8743
Telemetry [candidate] (8.646 ms) : 0, 8646
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052120
Total [baseline] (10.433 s) : 0, 10433383
Agent [candidate] (1.05 s) : 0, 1049923
Total [candidate] (10.423 s) : 0, 10422719
section appsec
Agent [baseline] (1.191 s) : 0, 1191264
Total [baseline] (10.755 s) : 0, 10755435
Agent [candidate] (1.195 s) : 0, 1195179
Total [candidate] (10.749 s) : 0, 10749467
section iast
Agent [baseline] (1.176 s) : 0, 1175816
Total [baseline] (10.998 s) : 0, 10997958
Agent [candidate] (1.178 s) : 0, 1178220
Total [candidate] (11.042 s) : 0, 11042105
section profiling
Agent [baseline] (1.279 s) : 0, 1278813
Total [baseline] (10.79 s) : 0, 10789846
Agent [candidate] (1.275 s) : 0, 1274636
Total [candidate] (10.874 s) : 0, 10874332
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.434 ms) : 0, 721434
BytebuddyAgent [candidate] (718.493 ms) : 0, 718493
GlobalTracer [baseline] (239.813 ms) : 0, 239813
GlobalTracer [candidate] (238.726 ms) : 0, 238726
AppSec [baseline] (54.576 ms) : 0, 54576
AppSec [candidate] (54.837 ms) : 0, 54837
Debugger [baseline] (4.431 ms) : 0, 4431
Debugger [candidate] (4.465 ms) : 0, 4465
Remote Config [baseline] (707.225 µs) : 0, 707
Remote Config [candidate] (703.299 µs) : 0, 703
Telemetry [baseline] (11.404 ms) : 0, 11404
Telemetry [candidate] (13.02 ms) : 0, 13020
section appsec
BytebuddyAgent [baseline] (736.408 ms) : 0, 736408
BytebuddyAgent [candidate] (739.444 ms) : 0, 739444
GlobalTracer [baseline] (234.659 ms) : 0, 234659
GlobalTracer [candidate] (235.716 ms) : 0, 235716
IAST [baseline] (21.574 ms) : 0, 21574
IAST [candidate] (22.062 ms) : 0, 22062
AppSec [baseline] (176.643 ms) : 0, 176643
AppSec [candidate] (176.136 ms) : 0, 176136
Debugger [baseline] (4.3 ms) : 0, 4300
Debugger [candidate] (4.287 ms) : 0, 4287
Remote Config [baseline] (644.649 µs) : 0, 645
Remote Config [candidate] (640.494 µs) : 0, 640
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.172 ms) : 0, 8172
section iast
BytebuddyAgent [baseline] (835.558 ms) : 0, 835558
BytebuddyAgent [candidate] (837.394 ms) : 0, 837394
GlobalTracer [baseline] (228.545 ms) : 0, 228545
GlobalTracer [candidate] (228.69 ms) : 0, 228690
IAST [baseline] (22.712 ms) : 0, 22712
IAST [candidate] (22.872 ms) : 0, 22872
AppSec [baseline] (55.817 ms) : 0, 55817
AppSec [candidate] (56.0 ms) : 0, 56000
Debugger [baseline] (4.197 ms) : 0, 4197
Debugger [candidate] (4.204 ms) : 0, 4204
Remote Config [baseline] (611.779 µs) : 0, 612
Remote Config [candidate] (602.37 µs) : 0, 602
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.767 ms) : 0, 8767
section profiling
BytebuddyAgent [baseline] (714.775 ms) : 0, 714775
BytebuddyAgent [candidate] (709.104 ms) : 0, 709104
GlobalTracer [baseline] (348.794 ms) : 0, 348794
GlobalTracer [candidate] (349.957 ms) : 0, 349957
AppSec [baseline] (54.122 ms) : 0, 54122
AppSec [candidate] (53.438 ms) : 0, 53438
Debugger [baseline] (4.288 ms) : 0, 4288
Debugger [candidate] (4.288 ms) : 0, 4288
Remote Config [baseline] (696.341 µs) : 0, 696
Remote Config [candidate] (699.404 µs) : 0, 699
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (8.987 ms) : 0, 8987
ProfilingAgent [baseline] (101.995 ms) : 0, 101995
ProfilingAgent [candidate] (103.415 ms) : 0, 103415
Profiling [baseline] (102.021 ms) : 0, 102021
Profiling [candidate] (103.44 ms) : 0, 103440
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1336, 1377
. : milestone, 1356,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.734 ms) : 1711, 1757
. : milestone, 1734,
code_origins (1.697 ms) : 1670, 1725
. : milestone, 1697,
iast (1.512 ms) : 1488, 1537
. : milestone, 1512,
profiling (1.522 ms) : 1498, 1545
. : milestone, 1522,
tracing (1.498 ms) : 1472, 1524
. : milestone, 1498,
section candidate
no_agent (1.36 ms) : 1339, 1381
. : milestone, 1360,
appsec (1.727 ms) : 1703, 1751
. : milestone, 1727,
appsec_no_iast (1.718 ms) : 1695, 1742
. : milestone, 1718,
code_origins (1.693 ms) : 1663, 1722
. : milestone, 1693,
iast (1.497 ms) : 1473, 1521
. : milestone, 1497,
profiling (1.511 ms) : 1487, 1534
. : milestone, 1511,
tracing (1.497 ms) : 1473, 1520
. : milestone, 1497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (380.461 µs) : 360, 400
. : milestone, 380,
iast (514.722 µs) : 493, 537
. : milestone, 515,
iast_FULL (735.322 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (571.041 µs) : 549, 593
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (510.667 µs) : 489, 533
. : milestone, 511,
iast_INACTIVE (459.554 µs) : 438, 481
. : milestone, 460,
iast_TELEMETRY_OFF (501.058 µs) : 479, 523
. : milestone, 501,
tracing (464.562 µs) : 443, 486
. : milestone, 465,
section candidate
no_agent (381.432 µs) : 362, 401
. : milestone, 381,
iast (511.584 µs) : 490, 533
. : milestone, 512,
iast_FULL (730.185 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (560.791 µs) : 539, 583
. : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (516.596 µs) : 495, 539
. : milestone, 517,
iast_INACTIVE (471.597 µs) : 449, 494
. : milestone, 472,
iast_TELEMETRY_OFF (502.75 µs) : 481, 525
. : milestone, 503,
tracing (458.625 µs) : 437, 480
. : milestone, 459,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.337 ms) : 2294, 2381
. : milestone, 2337,
iast (2.115 ms) : 2059, 2170
. : milestone, 2115,
iast_GLOBAL (2.156 ms) : 2101, 2212
. : milestone, 2156,
profiling (1.973 ms) : 1928, 2017
. : milestone, 1973,
tracing (1.951 ms) : 1908, 1993
. : milestone, 1951,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.342 ms) : 2298, 2385
. : milestone, 2342,
iast (2.116 ms) : 2060, 2171
. : milestone, 2116,
iast_GLOBAL (2.159 ms) : 2104, 2215
. : milestone, 2159,
profiling (1.967 ms) : 1923, 2010
. : milestone, 1967,
tracing (1.957 ms) : 1914, 2000
. : milestone, 1957,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~0a67281e95, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (15.54 s) : 15540000, 15540000
. : milestone, 15540000,
appsec (14.816 s) : 14816000, 14816000
. : milestone, 14816000,
iast (19.031 s) : 19031000, 19031000
. : milestone, 19031000,
iast_GLOBAL (18.207 s) : 18207000, 18207000
. : milestone, 18207000,
profiling (15.671 s) : 15671000, 15671000
. : milestone, 15671000,
tracing (15.202 s) : 15202000, 15202000
. : milestone, 15202000,
section candidate
no_agent (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
appsec (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
iast (18.473 s) : 18473000, 18473000
. : milestone, 18473000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
tracing (15.31 s) : 15310000, 15310000
. : milestone, 15310000,
|
amarziali
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Move capture and canceled continuation metrics to the same class (previously we only recorded a canceled continuation metric when pending trace was enabled, not when streaming spans)
Fixed finished continuation metric (this was in the wrong place which meant it was only recorded when closing message spans)
Motivation
More accurate metrics for continuations
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APMAPI-1271