-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Spock 2.3 #8634
Merged
Merged
Upgrade to Spock 2.3 #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053518
Total [baseline] (10.439 s) : 0, 10439049
Agent [candidate] (1.05 s) : 0, 1049881
Total [candidate] (10.442 s) : 0, 10442464
section appsec
Agent [baseline] (1.19 s) : 0, 1190499
Total [baseline] (10.771 s) : 0, 10771145
Agent [candidate] (1.194 s) : 0, 1194329
Total [candidate] (10.753 s) : 0, 10753213
section iast
Agent [baseline] (1.178 s) : 0, 1178339
Total [baseline] (11.029 s) : 0, 11029271
Agent [candidate] (1.177 s) : 0, 1177062
Total [candidate] (10.965 s) : 0, 10965327
section profiling
Agent [baseline] (1.27 s) : 0, 1270089
Total [baseline] (10.846 s) : 0, 10846454
Agent [candidate] (1.278 s) : 0, 1277760
Total [candidate] (10.853 s) : 0, 10853223
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.014 ms) : 0, 721014
BytebuddyAgent [candidate] (718.963 ms) : 0, 718963
GlobalTracer [baseline] (239.706 ms) : 0, 239706
GlobalTracer [candidate] (239.415 ms) : 0, 239415
AppSec [baseline] (54.409 ms) : 0, 54409
AppSec [candidate] (54.465 ms) : 0, 54465
Debugger [baseline] (5.135 ms) : 0, 5135
Debugger [candidate] (4.446 ms) : 0, 4446
Remote Config [baseline] (686.989 µs) : 0, 687
Remote Config [candidate] (710.604 µs) : 0, 711
Telemetry [baseline] (12.764 ms) : 0, 12764
Telemetry [candidate] (12.16 ms) : 0, 12160
section appsec
BytebuddyAgent [baseline] (736.251 ms) : 0, 736251
BytebuddyAgent [candidate] (738.249 ms) : 0, 738249
GlobalTracer [baseline] (235.045 ms) : 0, 235045
GlobalTracer [candidate] (235.733 ms) : 0, 235733
AppSec [baseline] (174.929 ms) : 0, 174929
AppSec [candidate] (176.018 ms) : 0, 176018
Debugger [baseline] (4.292 ms) : 0, 4292
Debugger [candidate] (4.307 ms) : 0, 4307
Remote Config [baseline] (641.114 µs) : 0, 641
Remote Config [candidate] (636.9 µs) : 0, 637
Telemetry [baseline] (8.873 ms) : 0, 8873
Telemetry [candidate] (8.892 ms) : 0, 8892
IAST [baseline] (21.466 ms) : 0, 21466
IAST [candidate] (21.596 ms) : 0, 21596
section iast
BytebuddyAgent [baseline] (837.215 ms) : 0, 837215
BytebuddyAgent [candidate] (836.847 ms) : 0, 836847
GlobalTracer [baseline] (229.05 ms) : 0, 229050
GlobalTracer [candidate] (228.698 ms) : 0, 228698
AppSec [baseline] (55.928 ms) : 0, 55928
AppSec [candidate] (55.68 ms) : 0, 55680
Debugger [baseline] (4.236 ms) : 0, 4236
Debugger [candidate] (4.172 ms) : 0, 4172
Remote Config [baseline] (602.375 µs) : 0, 602
Remote Config [candidate] (614.477 µs) : 0, 614
Telemetry [baseline] (8.768 ms) : 0, 8768
Telemetry [candidate] (8.787 ms) : 0, 8787
IAST [baseline] (22.873 ms) : 0, 22873
IAST [candidate] (22.654 ms) : 0, 22654
section profiling
BytebuddyAgent [baseline] (708.345 ms) : 0, 708345
BytebuddyAgent [candidate] (713.866 ms) : 0, 713866
GlobalTracer [baseline] (346.907 ms) : 0, 346907
GlobalTracer [candidate] (348.788 ms) : 0, 348788
AppSec [baseline] (54.275 ms) : 0, 54275
AppSec [candidate] (53.272 ms) : 0, 53272
Debugger [baseline] (4.204 ms) : 0, 4204
Debugger [candidate] (4.219 ms) : 0, 4219
Remote Config [baseline] (695.41 µs) : 0, 695
Remote Config [candidate] (687.315 µs) : 0, 687
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.819 ms) : 0, 8819
ProfilingAgent [baseline] (102.07 ms) : 0, 102070
ProfilingAgent [candidate] (102.556 ms) : 0, 102556
Profiling [baseline] (102.095 ms) : 0, 102095
Profiling [candidate] (102.584 ms) : 0, 102584
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1051754
Total [baseline] (8.689 s) : 0, 8689439
Agent [candidate] (1.049 s) : 0, 1048955
Total [candidate] (8.672 s) : 0, 8671572
section iast
Agent [baseline] (1.178 s) : 0, 1177743
Total [baseline] (9.227 s) : 0, 9226579
Agent [candidate] (1.18 s) : 0, 1179779
Total [candidate] (9.227 s) : 0, 9227051
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1185180
Total [baseline] (9.253 s) : 0, 9252814
Agent [candidate] (1.187 s) : 0, 1187201
Total [candidate] (9.222 s) : 0, 9221857
section iast_TELEMETRY_OFF
Agent [baseline] (1.173 s) : 0, 1173385
Total [baseline] (9.265 s) : 0, 9264886
Agent [candidate] (1.173 s) : 0, 1173461
Total [candidate] (9.236 s) : 0, 9235533
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.996 ms) : 0, 719996
BytebuddyAgent [candidate] (717.553 ms) : 0, 717553
GlobalTracer [baseline] (239.031 ms) : 0, 239031
GlobalTracer [candidate] (238.678 ms) : 0, 238678
AppSec [baseline] (54.8 ms) : 0, 54800
AppSec [candidate] (54.33 ms) : 0, 54330
Debugger [baseline] (4.448 ms) : 0, 4448
Debugger [candidate] (5.787 ms) : 0, 5787
Remote Config [baseline] (703.691 µs) : 0, 704
Remote Config [candidate] (694.471 µs) : 0, 694
Telemetry [baseline] (12.998 ms) : 0, 12998
Telemetry [candidate] (12.174 ms) : 0, 12174
section iast
BytebuddyAgent [baseline] (837.051 ms) : 0, 837051
BytebuddyAgent [candidate] (838.153 ms) : 0, 838153
GlobalTracer [baseline] (229.007 ms) : 0, 229007
GlobalTracer [candidate] (229.525 ms) : 0, 229525
AppSec [baseline] (55.851 ms) : 0, 55851
AppSec [candidate] (56.061 ms) : 0, 56061
Debugger [baseline] (4.167 ms) : 0, 4167
Debugger [candidate] (4.214 ms) : 0, 4214
Remote Config [baseline] (615.132 µs) : 0, 615
Remote Config [candidate] (606.062 µs) : 0, 606
Telemetry [baseline] (8.728 ms) : 0, 8728
Telemetry [candidate] (8.783 ms) : 0, 8783
IAST [baseline] (22.685 ms) : 0, 22685
IAST [candidate] (22.765 ms) : 0, 22765
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (842.528 ms) : 0, 842528
BytebuddyAgent [candidate] (844.028 ms) : 0, 844028
GlobalTracer [baseline] (229.797 ms) : 0, 229797
GlobalTracer [candidate] (230.26 ms) : 0, 230260
AppSec [baseline] (56.553 ms) : 0, 56553
AppSec [candidate] (56.285 ms) : 0, 56285
Debugger [baseline] (4.201 ms) : 0, 4201
Debugger [candidate] (4.239 ms) : 0, 4239
Remote Config [baseline] (611.504 µs) : 0, 612
Remote Config [candidate] (626.55 µs) : 0, 627
Telemetry [baseline] (8.833 ms) : 0, 8833
Telemetry [candidate] (8.868 ms) : 0, 8868
IAST [baseline] (23.006 ms) : 0, 23006
IAST [candidate] (23.065 ms) : 0, 23065
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.257 ms) : 0, 833257
BytebuddyAgent [candidate] (833.311 ms) : 0, 833311
GlobalTracer [baseline] (228.803 ms) : 0, 228803
GlobalTracer [candidate] (228.523 ms) : 0, 228523
AppSec [baseline] (55.746 ms) : 0, 55746
AppSec [candidate] (56.088 ms) : 0, 56088
Debugger [baseline] (4.151 ms) : 0, 4151
Debugger [candidate] (4.23 ms) : 0, 4230
Remote Config [baseline] (598.145 µs) : 0, 598
Remote Config [candidate] (592.229 µs) : 0, 592
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.716 ms) : 0, 8716
IAST [baseline] (22.55 ms) : 0, 22550
IAST [candidate] (22.39 ms) : 0, 22390
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (1.373 ms) : 1354, 1393
. : milestone, 1373,
appsec (1.745 ms) : 1721, 1769
. : milestone, 1745,
appsec_no_iast (1.75 ms) : 1727, 1774
. : milestone, 1750,
code_origins (1.702 ms) : 1676, 1728
. : milestone, 1702,
iast (1.528 ms) : 1504, 1553
. : milestone, 1528,
profiling (1.522 ms) : 1499, 1545
. : milestone, 1522,
tracing (1.503 ms) : 1478, 1528
. : milestone, 1503,
section candidate
no_agent (1.355 ms) : 1336, 1375
. : milestone, 1355,
appsec (1.73 ms) : 1706, 1754
. : milestone, 1730,
appsec_no_iast (1.747 ms) : 1723, 1770
. : milestone, 1747,
code_origins (1.716 ms) : 1688, 1743
. : milestone, 1716,
iast (1.54 ms) : 1516, 1564
. : milestone, 1540,
profiling (1.585 ms) : 1560, 1610
. : milestone, 1585,
tracing (1.517 ms) : 1493, 1542
. : milestone, 1517,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (384.815 µs) : 365, 405
. : milestone, 385,
iast (518.277 µs) : 496, 540
. : milestone, 518,
iast_FULL (735.806 µs) : 714, 758
. : milestone, 736,
iast_GLOBAL (565.971 µs) : 544, 588
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (519.603 µs) : 498, 542
. : milestone, 520,
iast_INACTIVE (470.454 µs) : 449, 492
. : milestone, 470,
iast_TELEMETRY_OFF (506.327 µs) : 485, 528
. : milestone, 506,
tracing (466.368 µs) : 445, 488
. : milestone, 466,
section candidate
no_agent (391.346 µs) : 371, 412
. : milestone, 391,
iast (519.055 µs) : 497, 541
. : milestone, 519,
iast_FULL (729.662 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (561.704 µs) : 540, 583
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (512.305 µs) : 491, 534
. : milestone, 512,
iast_INACTIVE (472.745 µs) : 451, 494
. : milestone, 473,
iast_TELEMETRY_OFF (498.865 µs) : 477, 520
. : milestone, 499,
tracing (463.575 µs) : 442, 485
. : milestone, 464,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (14.983 s) : 14983000, 14983000
. : milestone, 14983000,
appsec (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
iast (18.274 s) : 18274000, 18274000
. : milestone, 18274000,
iast_GLOBAL (17.998 s) : 17998000, 17998000
. : milestone, 17998000,
profiling (15.789 s) : 15789000, 15789000
. : milestone, 15789000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
section candidate
no_agent (15.318 s) : 15318000, 15318000
. : milestone, 15318000,
appsec (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
iast (18.415 s) : 18415000, 18415000
. : milestone, 18415000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.592 s) : 15592000, 15592000
. : milestone, 15592000,
tracing (15.522 s) : 15522000, 15522000
. : milestone, 15522000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~9098f10dc3, baseline=1.48.0-SNAPSHOT~52b943d46e
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1455, 1478
. : milestone, 1466,
appsec (2.335 ms) : 2292, 2379
. : milestone, 2335,
iast (2.114 ms) : 2058, 2170
. : milestone, 2114,
iast_GLOBAL (2.159 ms) : 2103, 2215
. : milestone, 2159,
profiling (1.97 ms) : 1926, 2014
. : milestone, 1970,
tracing (1.962 ms) : 1919, 2005
. : milestone, 1962,
section candidate
no_agent (1.465 ms) : 1454, 1476
. : milestone, 1465,
appsec (2.336 ms) : 2292, 2380
. : milestone, 2336,
iast (2.114 ms) : 2058, 2169
. : milestone, 2114,
iast_GLOBAL (2.159 ms) : 2103, 2215
. : milestone, 2159,
profiling (1.969 ms) : 1925, 2014
. : milestone, 1969,
tracing (1.95 ms) : 1907, 1992
. : milestone, 1950,
|
amarziali
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Release notes
RepeatUntilFailure
(PR) is particularly interesting for flaky test troubleshooting.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]