Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the Akka/Pekko checkpointing advice #8625

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Simplify the Akka/Pekko checkpointing advice #8625

merged 1 commit into from
Mar 27, 2025

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Mar 27, 2025 •
edited by jira bot
Loading

Motivation

Activate the task scope before checkpointing to make sure we can close it out in the right order, regardless whether it's already active or not before the advice. We can then simplify the rest of the advice because the checkpointing feature will close out any scopes that leaked out after the checkpoint.

Contributor Checklist

Jira ticket: APMAPI-960

@mcculls mcculls added tag: no release notes Changes to exclude from release notes type: refactoring inst: akka Akka instrumentation labels Mar 27, 2025
@mcculls mcculls force-pushed the mcculls/simplify-akka-pekko-checkpointing branch from d345c7f to 317eb6c Compare March 27, 2025 10:23
@pr-commenter
Copy link

pr-commenter bot commented Mar 27, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-akka-pekko-checkpointing
git_commit_date 1742990727 1743070977
git_commit_sha 3e2867a 317eb6c
release_version 1.48.0-SNAPSHOT~3e2867a84a 1.48.0-SNAPSHOT~317eb6c3b9
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743074092 1743074092
ci_job_id 867451272 867451272
ci_pipeline_id 60153417 60153417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ylcbzox4-project-304-concurrent-4-grp6ry18 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ylcbzox4-project-304-concurrent-4-grp6ry18 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 65 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045746
Total [baseline] (10.462 s) : 0, 10462293
Agent [candidate] (1.05 s) : 0, 1049967
Total [candidate] (10.567 s) : 0, 10566912
section appsec
Agent [baseline] (1.191 s) : 0, 1190857
Total [baseline] (10.74 s) : 0, 10739973
Agent [candidate] (1.196 s) : 0, 1195624
Total [candidate] (10.749 s) : 0, 10748845
section iast
Agent [baseline] (1.179 s) : 0, 1179253
Total [baseline] (11.015 s) : 0, 11015435
Agent [candidate] (1.181 s) : 0, 1180916
Total [candidate] (11.072 s) : 0, 11072352
section profiling
Agent [baseline] (1.275 s) : 0, 1275029
Total [baseline] (10.871 s) : 0, 10870529
Agent [candidate] (1.282 s) : 0, 1281582
Total [candidate] (10.993 s) : 0, 10993312
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.046 s -
Agent appsec 1.191 s 145.111 ms (13.9%)
Agent iast 1.179 s 133.507 ms (12.8%)
Agent profiling 1.275 s 229.283 ms (21.9%)
Total tracing 10.462 s -
Total appsec 10.74 s 277.68 ms (2.7%)
Total iast 11.015 s 553.141 ms (5.3%)
Total profiling 10.871 s 408.236 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.196 s 145.656 ms (13.9%)
Agent iast 1.181 s 130.949 ms (12.5%)
Agent profiling 1.282 s 231.615 ms (22.1%)
Total tracing 10.567 s -
Total appsec 10.749 s 181.933 ms (1.7%)
Total iast 11.072 s 505.441 ms (4.8%)
Total profiling 10.993 s 426.4 ms (4.0%) 
gantt
    title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.865 ms) : 0, 718865
BytebuddyAgent [candidate] (721.898 ms) : 0, 721898
GlobalTracer [baseline] (239.768 ms) : 0, 239768
GlobalTracer [candidate] (240.848 ms) : 0, 240848
AppSec [baseline] (54.513 ms) : 0, 54513
AppSec [candidate] (54.645 ms) : 0, 54645
Debugger [baseline] (4.42 ms) : 0, 4420
Debugger [candidate] (5.83 ms) : 0, 5830
Remote Config [baseline] (716.065 µs) : 0, 716
Remote Config [candidate] (725.481 µs) : 0, 725
Telemetry [baseline] (11.451 ms) : 0, 11451
Telemetry [candidate] (9.976 ms) : 0, 9976
section appsec
BytebuddyAgent [baseline] (737.534 ms) : 0, 737534
BytebuddyAgent [candidate] (740.692 ms) : 0, 740692
GlobalTracer [baseline] (236.951 ms) : 0, 236951
GlobalTracer [candidate] (237.911 ms) : 0, 237911
AppSec [baseline] (176.486 ms) : 0, 176486
AppSec [candidate] (176.516 ms) : 0, 176516
Debugger [baseline] (4.295 ms) : 0, 4295
Debugger [candidate] (4.298 ms) : 0, 4298
Remote Config [baseline] (645.69 µs) : 0, 646
Remote Config [candidate] (658.357 µs) : 0, 658
Telemetry [baseline] (8.173 ms) : 0, 8173
Telemetry [candidate] (8.527 ms) : 0, 8527
IAST [baseline] (21.479 ms) : 0, 21479
IAST [candidate] (21.774 ms) : 0, 21774
section iast
BytebuddyAgent [baseline] (840.056 ms) : 0, 840056
BytebuddyAgent [candidate] (841.266 ms) : 0, 841266
GlobalTracer [baseline] (231.187 ms) : 0, 231187
GlobalTracer [candidate] (231.177 ms) : 0, 231177
AppSec [baseline] (55.825 ms) : 0, 55825
AppSec [candidate] (55.972 ms) : 0, 55972
Debugger [baseline] (4.138 ms) : 0, 4138
Debugger [candidate] (4.155 ms) : 0, 4155
Remote Config [baseline] (595.034 µs) : 0, 595
Remote Config [candidate] (596.361 µs) : 0, 596
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.829 ms) : 0, 8829
IAST [baseline] (22.773 ms) : 0, 22773
IAST [candidate] (22.879 ms) : 0, 22879
section profiling
BytebuddyAgent [baseline] (711.546 ms) : 0, 711546
BytebuddyAgent [candidate] (716.451 ms) : 0, 716451
GlobalTracer [baseline] (351.157 ms) : 0, 351157
GlobalTracer [candidate] (352.966 ms) : 0, 352966
AppSec [baseline] (54.501 ms) : 0, 54501
AppSec [candidate] (53.878 ms) : 0, 53878
Debugger [baseline] (4.316 ms) : 0, 4316
Debugger [candidate] (4.313 ms) : 0, 4313
Remote Config [baseline] (714.336 µs) : 0, 714
Remote Config [candidate] (718.942 µs) : 0, 719
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (8.947 ms) : 0, 8947
ProfilingAgent [baseline] (102.018 ms) : 0, 102018
ProfilingAgent [candidate] (102.316 ms) : 0, 102316
Profiling [baseline] (102.043 ms) : 0, 102043
Profiling [candidate] (102.341 ms) : 0, 102341
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054235
Total [baseline] (8.72 s) : 0, 8720471
Agent [candidate] (1.057 s) : 0, 1057457
Total [candidate] (8.694 s) : 0, 8694279
section iast
Agent [baseline] (1.18 s) : 0, 1179912
Total [baseline] (9.249 s) : 0, 9248583
Agent [candidate] (1.179 s) : 0, 1178746
Total [candidate] (9.253 s) : 0, 9252656
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.177 s) : 0, 1177104
Total [baseline] (9.202 s) : 0, 9201830
Agent [candidate] (1.181 s) : 0, 1180544
Total [candidate] (9.242 s) : 0, 9242357
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175134
Total [baseline] (9.267 s) : 0, 9267457
Agent [candidate] (1.174 s) : 0, 1173968
Total [candidate] (9.228 s) : 0, 9228323
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.18 s 125.677 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 122.869 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.175 s 120.9 ms (11.5%)
Total tracing 8.72 s -
Total iast 9.249 s 528.112 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.202 s 481.359 ms (5.5%)
Total iast_TELEMETRY_OFF 9.267 s 546.986 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent iast 1.179 s 121.289 ms (11.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 123.087 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.174 s 116.51 ms (11.0%)
Total tracing 8.694 s -
Total iast 9.253 s 558.378 ms (6.4%)
Total iast_HARDCODED_SECRET_DISABLED 9.242 s 548.078 ms (6.3%)
Total iast_TELEMETRY_OFF 9.228 s 534.044 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.33 ms) : 0, 723330
BytebuddyAgent [candidate] (725.002 ms) : 0, 725002
GlobalTracer [baseline] (241.356 ms) : 0, 241356
GlobalTracer [candidate] (242.118 ms) : 0, 242118
AppSec [baseline] (55.133 ms) : 0, 55133
AppSec [candidate] (55.303 ms) : 0, 55303
Debugger [baseline] (4.449 ms) : 0, 4449
Debugger [candidate] (4.476 ms) : 0, 4476
Remote Config [baseline] (729.307 µs) : 0, 729
Remote Config [candidate] (739.591 µs) : 0, 740
Telemetry [baseline] (13.075 ms) : 0, 13075
Telemetry [candidate] (13.631 ms) : 0, 13631
section iast
BytebuddyAgent [baseline] (840.427 ms) : 0, 840427
BytebuddyAgent [candidate] (839.4 ms) : 0, 839400
GlobalTracer [baseline] (230.933 ms) : 0, 230933
GlobalTracer [candidate] (230.935 ms) : 0, 230935
AppSec [baseline] (56.095 ms) : 0, 56095
AppSec [candidate] (55.962 ms) : 0, 55962
Debugger [baseline] (4.132 ms) : 0, 4132
Debugger [candidate] (4.167 ms) : 0, 4167
Remote Config [baseline] (602.492 µs) : 0, 602
Remote Config [candidate] (609.995 µs) : 0, 610
Telemetry [baseline] (8.741 ms) : 0, 8741
Telemetry [candidate] (8.786 ms) : 0, 8786
IAST [baseline] (23.022 ms) : 0, 23022
IAST [candidate] (22.918 ms) : 0, 22918
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (838.124 ms) : 0, 838124
BytebuddyAgent [candidate] (841.252 ms) : 0, 841252
GlobalTracer [baseline] (230.692 ms) : 0, 230692
GlobalTracer [candidate] (231.3 ms) : 0, 231300
AppSec [baseline] (56.106 ms) : 0, 56106
AppSec [candidate] (55.659 ms) : 0, 55659
Debugger [baseline] (4.134 ms) : 0, 4134
Debugger [candidate] (4.12 ms) : 0, 4120
Remote Config [baseline] (599.504 µs) : 0, 600
Remote Config [candidate] (580.985 µs) : 0, 581
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.796 ms) : 0, 8796
IAST [baseline] (22.71 ms) : 0, 22710
IAST [candidate] (22.782 ms) : 0, 22782
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (836.564 ms) : 0, 836564
BytebuddyAgent [candidate] (835.621 ms) : 0, 835621
GlobalTracer [baseline] (230.523 ms) : 0, 230523
GlobalTracer [candidate] (230.302 ms) : 0, 230302
AppSec [baseline] (55.448 ms) : 0, 55448
AppSec [candidate] (56.363 ms) : 0, 56363
Debugger [baseline] (4.134 ms) : 0, 4134
Debugger [candidate] (4.135 ms) : 0, 4135
Remote Config [baseline] (597.324 µs) : 0, 597
Remote Config [candidate] (595.332 µs) : 0, 595
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.574 ms) : 0, 8574
IAST [baseline] (23.039 ms) : 0, 23039
IAST [candidate] (22.358 ms) : 0, 22358
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-03-27T10:47:04 2025-03-27T10:54:47
git_branch master mcculls/simplify-akka-pekko-checkpointing
git_commit_date 1742990727 1743070977
git_commit_sha 3e2867a 317eb6c
release_version 1.48.0-SNAPSHOT~3e2867a84a 1.48.0-SNAPSHOT~317eb6c3b9
start_time 2025-03-27T10:46:50 2025-03-27T10:54:33
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1743073285 1743073285
ci_job_id 867451273 867451273
ci_pipeline_id 60153417 60153417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-pm3myssn-project-304-concurrent-0-cgyfqwx3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-pm3myssn-project-304-concurrent-0-cgyfqwx3 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.384 ms) : 1364, 1403
.   : milestone, 1384,
appsec (1.743 ms) : 1719, 1767
.   : milestone, 1743,
appsec_no_iast (1.718 ms) : 1694, 1741
.   : milestone, 1718,
code_origins (1.671 ms) : 1644, 1699
.   : milestone, 1671,
iast (1.506 ms) : 1482, 1531
.   : milestone, 1506,
profiling (1.514 ms) : 1491, 1538
.   : milestone, 1514,
tracing (1.492 ms) : 1468, 1515
.   : milestone, 1492,
section candidate
no_agent (1.36 ms) : 1340, 1380
.   : milestone, 1360,
appsec (1.723 ms) : 1699, 1747
.   : milestone, 1723,
appsec_no_iast (1.748 ms) : 1726, 1771
.   : milestone, 1748,
code_origins (1.687 ms) : 1660, 1714
.   : milestone, 1687,
iast (1.5 ms) : 1475, 1526
.   : milestone, 1500,
profiling (1.547 ms) : 1522, 1573
.   : milestone, 1547,
tracing (1.493 ms) : 1469, 1517
.   : milestone, 1493,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.384 ms [1.364 ms, 1.403 ms] -
appsec 1.743 ms [1.719 ms, 1.767 ms] 359.454 µs (26.0%)
appsec_no_iast 1.718 ms [1.694 ms, 1.741 ms] 333.778 µs (24.1%)
code_origins 1.671 ms [1.644 ms, 1.699 ms] 287.452 µs (20.8%)
iast 1.506 ms [1.482 ms, 1.531 ms] 122.246 µs (8.8%)
profiling 1.514 ms [1.491 ms, 1.538 ms] 130.613 µs (9.4%)
tracing 1.492 ms [1.468 ms, 1.515 ms] 107.817 µs (7.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.38 ms] -
appsec 1.723 ms [1.699 ms, 1.747 ms] 363.019 µs (26.7%)
appsec_no_iast 1.748 ms [1.726 ms, 1.771 ms] 388.262 µs (28.6%)
code_origins 1.687 ms [1.66 ms, 1.714 ms] 327.201 µs (24.1%)
iast 1.5 ms [1.475 ms, 1.526 ms] 140.164 µs (10.3%)
profiling 1.547 ms [1.522 ms, 1.573 ms] 187.419 µs (13.8%)
tracing 1.493 ms [1.469 ms, 1.517 ms] 132.831 µs (9.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.285 µs) : 359, 401
.   : milestone, 380,
iast (511.435 µs) : 490, 533
.   : milestone, 511,
iast_FULL (733.201 µs) : 712, 755
.   : milestone, 733,
iast_GLOBAL (553.115 µs) : 532, 575
.   : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (516.864 µs) : 494, 539
.   : milestone, 517,
iast_INACTIVE (464.42 µs) : 443, 485
.   : milestone, 464,
iast_TELEMETRY_OFF (495.826 µs) : 474, 518
.   : milestone, 496,
tracing (458.331 µs) : 437, 479
.   : milestone, 458,
section candidate
no_agent (377.35 µs) : 358, 397
.   : milestone, 377,
iast (514.586 µs) : 492, 537
.   : milestone, 515,
iast_FULL (728.697 µs) : 706, 751
.   : milestone, 729,
iast_GLOBAL (566.293 µs) : 544, 589
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (498.562 µs) : 476, 521
.   : milestone, 499,
iast_INACTIVE (461.707 µs) : 440, 483
.   : milestone, 462,
iast_TELEMETRY_OFF (499.206 µs) : 477, 521
.   : milestone, 499,
tracing (453.464 µs) : 433, 474
.   : milestone, 453,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.285 µs [359.364 µs, 401.207 µs] -
iast 511.435 µs [489.63 µs, 533.239 µs] 131.15 µs (34.5%)
iast_FULL 733.201 µs [711.529 µs, 754.874 µs] 352.916 µs (92.8%)
iast_GLOBAL 553.115 µs [531.532 µs, 574.699 µs] 172.83 µs (45.4%)
iast_HARDCODED_SECRET_DISABLED 516.864 µs [494.409 µs, 539.318 µs] 136.578 µs (35.9%)
iast_INACTIVE 464.42 µs [443.495 µs, 485.345 µs] 84.135 µs (22.1%)
iast_TELEMETRY_OFF 495.826 µs [473.689 µs, 517.962 µs] 115.54 µs (30.4%)
tracing 458.331 µs [437.247 µs, 479.416 µs] 78.046 µs (20.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.35 µs [357.565 µs, 397.135 µs] -
iast 514.586 µs [492.456 µs, 536.716 µs] 137.236 µs (36.4%)
iast_FULL 728.697 µs [706.132 µs, 751.262 µs] 351.347 µs (93.1%)
iast_GLOBAL 566.293 µs [544.01 µs, 588.577 µs] 188.943 µs (50.1%)
iast_HARDCODED_SECRET_DISABLED 498.562 µs [475.814 µs, 521.309 µs] 121.212 µs (32.1%)
iast_INACTIVE 461.707 µs [440.481 µs, 482.933 µs] 84.357 µs (22.4%)
iast_TELEMETRY_OFF 499.206 µs [477.082 µs, 521.33 µs] 121.856 µs (32.3%)
tracing 453.464 µs [432.794 µs, 474.135 µs] 76.114 µs (20.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/simplify-akka-pekko-checkpointing
git_commit_date 1742990727 1743070977
git_commit_sha 3e2867a 317eb6c
release_version 1.48.0-SNAPSHOT~3e2867a84a 1.48.0-SNAPSHOT~317eb6c3b9
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1743073762 1743073762
ci_job_id 867451274 867451274
ci_pipeline_id 60153417 60153417
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ylcbzox4-project-304-concurrent-5-tlgaalh6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ylcbzox4-project-304-concurrent-5-tlgaalh6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
appsec (14.823 s) : 14823000, 14823000
.   : milestone, 14823000,
iast (18.812 s) : 18812000, 18812000
.   : milestone, 18812000,
iast_GLOBAL (18.165 s) : 18165000, 18165000
.   : milestone, 18165000,
profiling (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
tracing (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
section candidate
no_agent (15.446 s) : 15446000, 15446000
.   : milestone, 15446000,
appsec (14.884 s) : 14884000, 14884000
.   : milestone, 14884000,
iast (18.665 s) : 18665000, 18665000
.   : milestone, 18665000,
iast_GLOBAL (17.933 s) : 17933000, 17933000
.   : milestone, 17933000,
profiling (15.184 s) : 15184000, 15184000
.   : milestone, 15184000,
tracing (15.137 s) : 15137000, 15137000
.   : milestone, 15137000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.817 s [14.817 s, 14.817 s] -
appsec 14.823 s [14.823 s, 14.823 s] 6.0 ms (0.0%)
iast 18.812 s [18.812 s, 18.812 s] 3.995 s (27.0%)
iast_GLOBAL 18.165 s [18.165 s, 18.165 s] 3.348 s (22.6%)
profiling 15.006 s [15.006 s, 15.006 s] 189.0 ms (1.3%)
tracing 15.026 s [15.026 s, 15.026 s] 209.0 ms (1.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.446 s [15.446 s, 15.446 s] -
appsec 14.884 s [14.884 s, 14.884 s] -562.0 ms (-3.6%)
iast 18.665 s [18.665 s, 18.665 s] 3.219 s (20.8%)
iast_GLOBAL 17.933 s [17.933 s, 17.933 s] 2.487 s (16.1%)
profiling 15.184 s [15.184 s, 15.184 s] -262.0 ms (-1.7%)
tracing 15.137 s [15.137 s, 15.137 s] -309.0 ms (-2.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~317eb6c3b9, baseline=1.48.0-SNAPSHOT~3e2867a84a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.336 ms) : 2292, 2379
.   : milestone, 2336,
iast (2.134 ms) : 2079, 2190
.   : milestone, 2134,
iast_GLOBAL (2.169 ms) : 2113, 2225
.   : milestone, 2169,
profiling (2.0 ms) : 1954, 2047
.   : milestone, 2000,
tracing (1.96 ms) : 1917, 2003
.   : milestone, 1960,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.354 ms) : 2310, 2397
.   : milestone, 2354,
iast (2.128 ms) : 2072, 2183
.   : milestone, 2128,
iast_GLOBAL (2.176 ms) : 2120, 2232
.   : milestone, 2176,
profiling (1.996 ms) : 1950, 2041
.   : milestone, 1996,
tracing (1.967 ms) : 1924, 2010
.   : milestone, 1967,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.336 ms [2.292 ms, 2.379 ms] 861.597 µs (58.4%)
iast 2.134 ms [2.079 ms, 2.19 ms] 660.275 µs (44.8%)
iast_GLOBAL 2.169 ms [2.113 ms, 2.225 ms] 694.876 µs (47.1%)
profiling 2.0 ms [1.954 ms, 2.047 ms] 526.293 µs (35.7%)
tracing 1.96 ms [1.917 ms, 2.003 ms] 485.884 µs (33.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.354 ms [2.31 ms, 2.397 ms] 877.482 µs (59.4%)
iast 2.128 ms [2.072 ms, 2.183 ms] 651.357 µs (44.1%)
iast_GLOBAL 2.176 ms [2.12 ms, 2.232 ms] 700.031 µs (47.4%)
profiling 1.996 ms [1.95 ms, 2.041 ms] 519.516 µs (35.2%)
tracing 1.967 ms [1.924 ms, 2.01 ms] 490.909 µs (33.3%)

@mcculls mcculls marked this pull request as ready for review March 27, 2025 11:52
@mcculls mcculls requested a review from a team as a code owner March 27, 2025 11:52
@mcculls mcculls requested a review from amarziali March 27, 2025 11:53
amarziali
amarziali approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok thank you!

@mcculls mcculls merged commit 60f8046 into master Mar 27, 2025
270 checks passed
@mcculls mcculls deleted the mcculls/simplify-akka-pekko-checkpointing branch March 27, 2025 14:30
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

Assignees
No one assigned
Labels
inst: akka Akka instrumentation tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @amarziali