-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create metric: appsec.rasp.rule.skipped #8618
Merged
jandro996
merged 2 commits into
master
from
alejandro.gonzalez/Create-metric-appsec.rasp.rule.skipped
Mar 26, 2025
Merged
Create metric: appsec.rasp.rule.skipped #8618
jandro996
merged 2 commits into
master
from
alejandro.gonzalez/Create-metric-appsec.rasp.rule.skipped
Mar 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 4 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047406
Total [baseline] (10.494 s) : 0, 10493929
Agent [candidate] (1.043 s) : 0, 1042729
Total [candidate] (10.427 s) : 0, 10426761
section appsec
Agent [baseline] (1.189 s) : 0, 1189222
Total [baseline] (10.765 s) : 0, 10764915
Agent [candidate] (1.184 s) : 0, 1184214
Total [candidate] (10.783 s) : 0, 10782586
section iast
Agent [baseline] (1.189 s) : 0, 1188876
Total [baseline] (11.025 s) : 0, 11024813
Agent [candidate] (1.175 s) : 0, 1174931
Total [candidate] (11.086 s) : 0, 11086482
section profiling
Agent [baseline] (1.275 s) : 0, 1275021
Total [baseline] (10.843 s) : 0, 10843370
Agent [candidate] (1.269 s) : 0, 1269390
Total [candidate] (10.916 s) : 0, 10916109
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.707 ms) : 0, 719707
BytebuddyAgent [candidate] (718.633 ms) : 0, 718633
GlobalTracer [baseline] (240.591 ms) : 0, 240591
GlobalTracer [candidate] (239.773 ms) : 0, 239773
AppSec [baseline] (55.063 ms) : 0, 55063
AppSec [candidate] (55.068 ms) : 0, 55068
Remote Config [baseline] (719.041 µs) : 0, 719
Remote Config [candidate] (707.245 µs) : 0, 707
Telemetry [baseline] (10.118 ms) : 0, 10118
Telemetry [candidate] (12.429 ms) : 0, 12429
Debugger [baseline] (5.138 ms) : 0, 5138
section appsec
BytebuddyAgent [baseline] (736.323 ms) : 0, 736323
BytebuddyAgent [candidate] (735.845 ms) : 0, 735845
GlobalTracer [baseline] (236.463 ms) : 0, 236463
GlobalTracer [candidate] (236.299 ms) : 0, 236299
AppSec [baseline] (176.581 ms) : 0, 176581
AppSec [candidate] (176.042 ms) : 0, 176042
Remote Config [baseline] (647.537 µs) : 0, 648
Remote Config [candidate] (657.706 µs) : 0, 658
Telemetry [baseline] (8.171 ms) : 0, 8171
Telemetry [candidate] (8.638 ms) : 0, 8638
Debugger [baseline] (4.282 ms) : 0, 4282
IAST [baseline] (21.439 ms) : 0, 21439
IAST [candidate] (21.574 ms) : 0, 21574
section iast
BytebuddyAgent [baseline] (847.429 ms) : 0, 847429
BytebuddyAgent [candidate] (840.531 ms) : 0, 840531
GlobalTracer [baseline] (231.988 ms) : 0, 231988
GlobalTracer [candidate] (230.3 ms) : 0, 230300
AppSec [baseline] (56.538 ms) : 0, 56538
AppSec [candidate] (56.122 ms) : 0, 56122
Remote Config [baseline] (602.775 µs) : 0, 603
Remote Config [candidate] (625.884 µs) : 0, 626
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.699 ms) : 0, 8699
Debugger [baseline] (4.231 ms) : 0, 4231
IAST [baseline] (23.064 ms) : 0, 23064
IAST [candidate] (22.68 ms) : 0, 22680
section profiling
BytebuddyAgent [baseline] (710.677 ms) : 0, 710677
BytebuddyAgent [candidate] (714.83 ms) : 0, 714830
GlobalTracer [baseline] (351.8 ms) : 0, 351800
GlobalTracer [candidate] (352.134 ms) : 0, 352134
AppSec [baseline] (54.581 ms) : 0, 54581
AppSec [candidate] (54.451 ms) : 0, 54451
Remote Config [baseline] (700.433 µs) : 0, 700
Remote Config [candidate] (722.043 µs) : 0, 722
Telemetry [baseline] (8.922 ms) : 0, 8922
Telemetry [candidate] (8.933 ms) : 0, 8933
Debugger [baseline] (4.308 ms) : 0, 4308
ProfilingAgent [baseline] (102.193 ms) : 0, 102193
ProfilingAgent [candidate] (96.566 ms) : 0, 96566
Profiling [baseline] (102.36 ms) : 0, 102360
Profiling [candidate] (96.591 ms) : 0, 96591
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049938
Total [baseline] (8.69 s) : 0, 8690284
Agent [candidate] (1.045 s) : 0, 1044527
Total [candidate] (8.67 s) : 0, 8669972
section iast
Agent [baseline] (1.177 s) : 0, 1176746
Total [baseline] (9.268 s) : 0, 9268223
Agent [candidate] (1.197 s) : 0, 1196900
Total [candidate] (9.288 s) : 0, 9288435
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1179068
Total [baseline] (9.229 s) : 0, 9228930
Agent [candidate] (1.181 s) : 0, 1181451
Total [candidate] (9.337 s) : 0, 9336813
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1174442
Total [baseline] (9.276 s) : 0, 9276329
Agent [candidate] (1.17 s) : 0, 1170407
Total [candidate] (9.263 s) : 0, 9263055
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.761 ms) : 0, 718761
BytebuddyAgent [candidate] (718.65 ms) : 0, 718650
GlobalTracer [baseline] (239.792 ms) : 0, 239792
GlobalTracer [candidate] (239.398 ms) : 0, 239398
AppSec [baseline] (54.98 ms) : 0, 54980
AppSec [candidate] (54.522 ms) : 0, 54522
Remote Config [baseline] (726.414 µs) : 0, 726
Remote Config [candidate] (684.314 µs) : 0, 684
Telemetry [baseline] (15.269 ms) : 0, 15269
Telemetry [candidate] (15.219 ms) : 0, 15219
Debugger [baseline] (4.409 ms) : 0, 4409
section iast
BytebuddyAgent [baseline] (838.345 ms) : 0, 838345
BytebuddyAgent [candidate] (857.387 ms) : 0, 857387
GlobalTracer [baseline] (230.411 ms) : 0, 230411
GlobalTracer [candidate] (233.323 ms) : 0, 233323
AppSec [baseline] (55.695 ms) : 0, 55695
AppSec [candidate] (56.161 ms) : 0, 56161
Remote Config [baseline] (604.44 µs) : 0, 604
Remote Config [candidate] (629.252 µs) : 0, 629
Telemetry [baseline] (8.775 ms) : 0, 8775
Telemetry [candidate] (8.876 ms) : 0, 8876
Debugger [baseline] (4.185 ms) : 0, 4185
IAST [baseline] (22.823 ms) : 0, 22823
IAST [candidate] (24.213 ms) : 0, 24213
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (840.025 ms) : 0, 840025
BytebuddyAgent [candidate] (844.22 ms) : 0, 844220
GlobalTracer [baseline] (230.885 ms) : 0, 230885
GlobalTracer [candidate] (232.112 ms) : 0, 232112
AppSec [baseline] (55.801 ms) : 0, 55801
AppSec [candidate] (56.419 ms) : 0, 56419
Remote Config [baseline] (596.546 µs) : 0, 597
Remote Config [candidate] (624.764 µs) : 0, 625
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.859 ms) : 0, 8859
Debugger [baseline] (4.133 ms) : 0, 4133
IAST [baseline] (22.8 ms) : 0, 22800
IAST [candidate] (23.088 ms) : 0, 23088
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.979 ms) : 0, 835979
BytebuddyAgent [candidate] (836.359 ms) : 0, 836359
GlobalTracer [baseline] (230.495 ms) : 0, 230495
GlobalTracer [candidate] (230.481 ms) : 0, 230481
AppSec [baseline] (56.199 ms) : 0, 56199
AppSec [candidate] (56.038 ms) : 0, 56038
Remote Config [baseline] (597.563 µs) : 0, 598
Remote Config [candidate] (611.477 µs) : 0, 611
Telemetry [baseline] (8.594 ms) : 0, 8594
Telemetry [candidate] (8.597 ms) : 0, 8597
Debugger [baseline] (4.148 ms) : 0, 4148
IAST [baseline] (22.398 ms) : 0, 22398
IAST [candidate] (22.342 ms) : 0, 22342
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section baseline
no_agent (380.993 µs) : 361, 401
. : milestone, 381,
iast (518.066 µs) : 496, 540
. : milestone, 518,
iast_FULL (742.854 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (569.605 µs) : 547, 592
. : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (515.276 µs) : 494, 537
. : milestone, 515,
iast_INACTIVE (465.249 µs) : 444, 486
. : milestone, 465,
iast_TELEMETRY_OFF (510.112 µs) : 488, 532
. : milestone, 510,
tracing (459.037 µs) : 438, 480
. : milestone, 459,
section candidate
no_agent (384.098 µs) : 365, 404
. : milestone, 384,
iast (519.974 µs) : 498, 542
. : milestone, 520,
iast_FULL (732.138 µs) : 709, 755
. : milestone, 732,
iast_GLOBAL (561.674 µs) : 540, 583
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (519.205 µs) : 498, 541
. : milestone, 519,
iast_INACTIVE (473.231 µs) : 452, 494
. : milestone, 473,
iast_TELEMETRY_OFF (506.603 µs) : 485, 528
. : milestone, 507,
tracing (463.489 µs) : 443, 484
. : milestone, 463,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section baseline
no_agent (1.38 ms) : 1361, 1400
. : milestone, 1380,
appsec (1.744 ms) : 1721, 1767
. : milestone, 1744,
appsec_no_iast (1.739 ms) : 1716, 1761
. : milestone, 1739,
code_origins (1.652 ms) : 1625, 1679
. : milestone, 1652,
iast (1.514 ms) : 1490, 1538
. : milestone, 1514,
profiling (1.574 ms) : 1549, 1599
. : milestone, 1574,
tracing (1.535 ms) : 1510, 1559
. : milestone, 1535,
section candidate
no_agent (1.377 ms) : 1357, 1397
. : milestone, 1377,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.743 ms) : 1717, 1769
. : milestone, 1743,
code_origins (1.679 ms) : 1652, 1707
. : milestone, 1679,
iast (1.519 ms) : 1493, 1544
. : milestone, 1519,
profiling (1.533 ms) : 1509, 1558
. : milestone, 1533,
tracing (1.494 ms) : 1469, 1519
. : milestone, 1494,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section baseline
no_agent (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.89 s) : 18890000, 18890000
. : milestone, 18890000,
iast_GLOBAL (17.825 s) : 17825000, 17825000
. : milestone, 17825000,
profiling (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
tracing (15.013 s) : 15013000, 15013000
. : milestone, 15013000,
section candidate
no_agent (15.238 s) : 15238000, 15238000
. : milestone, 15238000,
appsec (15.145 s) : 15145000, 15145000
. : milestone, 15145000,
iast (19.04 s) : 19040000, 19040000
. : milestone, 19040000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~638b0b5f8c, baseline=1.48.0-SNAPSHOT~fe8895f92a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.352 ms) : 2308, 2396
. : milestone, 2352,
iast (2.123 ms) : 2068, 2179
. : milestone, 2123,
iast_GLOBAL (2.167 ms) : 2111, 2222
. : milestone, 2167,
profiling (1.972 ms) : 1928, 2017
. : milestone, 1972,
tracing (1.958 ms) : 1915, 2000
. : milestone, 1958,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.348 ms) : 2304, 2392
. : milestone, 2348,
iast (2.127 ms) : 2071, 2183
. : milestone, 2127,
iast_GLOBAL (2.175 ms) : 2119, 2232
. : milestone, 2175,
profiling (1.966 ms) : 1922, 2010
. : milestone, 1966,
tracing (1.946 ms) : 1903, 1989
. : milestone, 1946,
|
manuel-alvarez-alvarez
approved these changes
Mar 25, 2025
smola
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Crate the appsec.rasp.rule.skipped metric that counts the number of times that waf call is skipped due to the WAF context is closed
Motivation
Additional Notes
Although the metric reason tag supports after-request and before-request only the first one is implemented, as there are no use cases in java tracer for the before-request
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-56629