-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Inherited decision maker is a meta" #8617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fd04663.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047363
Total [baseline] (10.479 s) : 0, 10478518
Agent [candidate] (1.047 s) : 0, 1046678
Total [candidate] (10.442 s) : 0, 10442113
section appsec
Agent [baseline] (1.19 s) : 0, 1190452
Total [baseline] (10.782 s) : 0, 10782210
Agent [candidate] (1.194 s) : 0, 1193701
Total [candidate] (10.829 s) : 0, 10828717
section iast
Agent [baseline] (1.182 s) : 0, 1182232
Total [baseline] (11.04 s) : 0, 11039918
Agent [candidate] (1.184 s) : 0, 1183934
Total [candidate] (11.04 s) : 0, 11040320
section profiling
Agent [baseline] (1.285 s) : 0, 1284873
Total [baseline] (10.857 s) : 0, 10856926
Agent [candidate] (1.275 s) : 0, 1275286
Total [candidate] (10.861 s) : 0, 10860885
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.01 ms) : 0, 719010
BytebuddyAgent [candidate] (719.397 ms) : 0, 719397
GlobalTracer [baseline] (240.384 ms) : 0, 240384
GlobalTracer [candidate] (240.446 ms) : 0, 240446
AppSec [baseline] (54.62 ms) : 0, 54620
AppSec [candidate] (54.86 ms) : 0, 54860
Debugger [baseline] (5.18 ms) : 0, 5180
Debugger [candidate] (4.426 ms) : 0, 4426
Remote Config [baseline] (714.731 µs) : 0, 715
Remote Config [candidate] (742.502 µs) : 0, 743
Telemetry [baseline] (11.379 ms) : 0, 11379
Telemetry [candidate] (10.741 ms) : 0, 10741
section appsec
BytebuddyAgent [baseline] (737.292 ms) : 0, 737292
BytebuddyAgent [candidate] (739.501 ms) : 0, 739501
GlobalTracer [baseline] (236.853 ms) : 0, 236853
GlobalTracer [candidate] (237.446 ms) : 0, 237446
AppSec [baseline] (175.851 ms) : 0, 175851
AppSec [candidate] (176.222 ms) : 0, 176222
Debugger [baseline] (4.31 ms) : 0, 4310
Debugger [candidate] (4.335 ms) : 0, 4335
Remote Config [baseline] (644.768 µs) : 0, 645
Remote Config [candidate] (650.913 µs) : 0, 651
Telemetry [baseline] (8.581 ms) : 0, 8581
Telemetry [candidate] (8.589 ms) : 0, 8589
IAST [baseline] (21.761 ms) : 0, 21761
IAST [candidate] (21.72 ms) : 0, 21720
section iast
BytebuddyAgent [baseline] (842.23 ms) : 0, 842230
BytebuddyAgent [candidate] (842.114 ms) : 0, 842114
GlobalTracer [baseline] (231.55 ms) : 0, 231550
GlobalTracer [candidate] (232.784 ms) : 0, 232784
AppSec [baseline] (55.938 ms) : 0, 55938
AppSec [candidate] (56.323 ms) : 0, 56323
Debugger [baseline] (4.189 ms) : 0, 4189
Debugger [candidate] (4.179 ms) : 0, 4179
Remote Config [baseline] (600.747 µs) : 0, 601
Remote Config [candidate] (597.252 µs) : 0, 597
Telemetry [baseline] (8.742 ms) : 0, 8742
Telemetry [candidate] (8.846 ms) : 0, 8846
IAST [baseline] (22.951 ms) : 0, 22951
IAST [candidate] (23.034 ms) : 0, 23034
section profiling
ProfilingAgent [baseline] (102.451 ms) : 0, 102451
ProfilingAgent [candidate] (102.362 ms) : 0, 102362
BytebuddyAgent [baseline] (717.758 ms) : 0, 717758
BytebuddyAgent [candidate] (711.899 ms) : 0, 711899
GlobalTracer [baseline] (353.3 ms) : 0, 353300
GlobalTracer [candidate] (351.711 ms) : 0, 351711
AppSec [baseline] (55.083 ms) : 0, 55083
AppSec [candidate] (53.6 ms) : 0, 53600
Debugger [baseline] (4.338 ms) : 0, 4338
Debugger [candidate] (4.293 ms) : 0, 4293
Remote Config [baseline] (718.213 µs) : 0, 718
Remote Config [candidate] (699.787 µs) : 0, 700
Telemetry [baseline] (9.074 ms) : 0, 9074
Telemetry [candidate] (9.037 ms) : 0, 9037
Profiling [baseline] (102.476 ms) : 0, 102476
Profiling [candidate] (102.389 ms) : 0, 102389
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1049298
Total [baseline] (8.696 s) : 0, 8696048
Agent [candidate] (1.057 s) : 0, 1056688
Total [candidate] (8.676 s) : 0, 8676176
section iast
Agent [baseline] (1.187 s) : 0, 1186755
Total [baseline] (9.248 s) : 0, 9248463
Agent [candidate] (1.181 s) : 0, 1180841
Total [candidate] (9.348 s) : 0, 9348046
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180793
Total [baseline] (9.23 s) : 0, 9229717
Agent [candidate] (1.19 s) : 0, 1189940
Total [candidate] (9.273 s) : 0, 9272885
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173619
Total [baseline] (9.218 s) : 0, 9217787
Agent [candidate] (1.178 s) : 0, 1178303
Total [candidate] (9.289 s) : 0, 9289280
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.627 ms) : 0, 718627
BytebuddyAgent [candidate] (722.304 ms) : 0, 722304
GlobalTracer [baseline] (239.78 ms) : 0, 239780
GlobalTracer [candidate] (241.994 ms) : 0, 241994
AppSec [baseline] (54.676 ms) : 0, 54676
AppSec [candidate] (55.05 ms) : 0, 55050
Debugger [baseline] (4.425 ms) : 0, 4425
Debugger [candidate] (4.445 ms) : 0, 4445
Remote Config [baseline] (729.617 µs) : 0, 730
Remote Config [candidate] (715.663 µs) : 0, 716
Telemetry [baseline] (15.05 ms) : 0, 15050
Telemetry [candidate] (16.043 ms) : 0, 16043
section iast
BytebuddyAgent [baseline] (846.285 ms) : 0, 846285
BytebuddyAgent [candidate] (840.903 ms) : 0, 840903
GlobalTracer [baseline] (231.374 ms) : 0, 231374
GlobalTracer [candidate] (231.147 ms) : 0, 231147
AppSec [baseline] (56.254 ms) : 0, 56254
AppSec [candidate] (56.068 ms) : 0, 56068
Debugger [baseline] (4.213 ms) : 0, 4213
Debugger [candidate] (4.186 ms) : 0, 4186
Remote Config [baseline] (609.513 µs) : 0, 610
Remote Config [candidate] (594.881 µs) : 0, 595
Telemetry [baseline] (8.812 ms) : 0, 8812
Telemetry [candidate] (8.772 ms) : 0, 8772
IAST [baseline] (23.106 ms) : 0, 23106
IAST [candidate] (23.074 ms) : 0, 23074
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.438 ms) : 0, 841438
BytebuddyAgent [candidate] (846.806 ms) : 0, 846806
GlobalTracer [baseline] (230.967 ms) : 0, 230967
GlobalTracer [candidate] (233.096 ms) : 0, 233096
AppSec [baseline] (55.353 ms) : 0, 55353
AppSec [candidate] (56.128 ms) : 0, 56128
Debugger [baseline] (4.173 ms) : 0, 4173
Debugger [candidate] (4.237 ms) : 0, 4237
Remote Config [baseline] (599.847 µs) : 0, 600
Remote Config [candidate] (604.118 µs) : 0, 604
Telemetry [baseline] (8.787 ms) : 0, 8787
Telemetry [candidate] (9.035 ms) : 0, 9035
IAST [baseline] (23.513 ms) : 0, 23513
IAST [candidate] (23.946 ms) : 0, 23946
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.804 ms) : 0, 834804
BytebuddyAgent [candidate] (839.44 ms) : 0, 839440
GlobalTracer [baseline] (230.606 ms) : 0, 230606
GlobalTracer [candidate] (231.55 ms) : 0, 231550
AppSec [baseline] (56.323 ms) : 0, 56323
AppSec [candidate] (55.687 ms) : 0, 55687
Debugger [baseline] (4.172 ms) : 0, 4172
Debugger [candidate] (4.07 ms) : 0, 4070
Remote Config [baseline] (600.523 µs) : 0, 601
Remote Config [candidate] (598.302 µs) : 0, 598
Telemetry [baseline] (8.686 ms) : 0, 8686
Telemetry [candidate] (8.603 ms) : 0, 8603
IAST [baseline] (22.39 ms) : 0, 22390
IAST [candidate] (22.351 ms) : 0, 22351
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section baseline
no_agent (383.42 µs) : 362, 405
. : milestone, 383,
iast (517.34 µs) : 495, 539
. : milestone, 517,
iast_FULL (730.091 µs) : 708, 752
. : milestone, 730,
iast_GLOBAL (561.969 µs) : 540, 584
. : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (513.36 µs) : 491, 535
. : milestone, 513,
iast_INACTIVE (468.092 µs) : 447, 489
. : milestone, 468,
iast_TELEMETRY_OFF (505.51 µs) : 483, 528
. : milestone, 506,
tracing (454.521 µs) : 434, 475
. : milestone, 455,
section candidate
no_agent (383.83 µs) : 363, 405
. : milestone, 384,
iast (510.641 µs) : 489, 532
. : milestone, 511,
iast_FULL (734.61 µs) : 712, 757
. : milestone, 735,
iast_GLOBAL (571.563 µs) : 549, 594
. : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (519.146 µs) : 497, 541
. : milestone, 519,
iast_INACTIVE (460.543 µs) : 439, 482
. : milestone, 461,
iast_TELEMETRY_OFF (504.277 µs) : 482, 526
. : milestone, 504,
tracing (464.347 µs) : 443, 486
. : milestone, 464,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.36 ms) : 1339, 1380
. : milestone, 1360,
appsec (1.751 ms) : 1727, 1775
. : milestone, 1751,
appsec_no_iast (1.744 ms) : 1721, 1768
. : milestone, 1744,
code_origins (1.701 ms) : 1675, 1727
. : milestone, 1701,
iast (1.512 ms) : 1487, 1536
. : milestone, 1512,
profiling (1.542 ms) : 1517, 1567
. : milestone, 1542,
tracing (1.493 ms) : 1467, 1518
. : milestone, 1493,
section candidate
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.729 ms) : 1705, 1752
. : milestone, 1729,
appsec_no_iast (1.731 ms) : 1707, 1754
. : milestone, 1731,
code_origins (1.674 ms) : 1647, 1702
. : milestone, 1674,
iast (1.518 ms) : 1493, 1542
. : milestone, 1518,
profiling (1.522 ms) : 1499, 1546
. : milestone, 1522,
tracing (1.5 ms) : 1476, 1524
. : milestone, 1500,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (2.333 ms) : 2289, 2376
. : milestone, 2333,
iast (2.116 ms) : 2060, 2171
. : milestone, 2116,
iast_GLOBAL (2.155 ms) : 2099, 2210
. : milestone, 2155,
profiling (1.959 ms) : 1915, 2002
. : milestone, 1959,
tracing (1.94 ms) : 1898, 1982
. : milestone, 1940,
section candidate
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.342 ms) : 2298, 2385
. : milestone, 2342,
iast (2.116 ms) : 2061, 2171
. : milestone, 2116,
iast_GLOBAL (2.153 ms) : 2097, 2208
. : milestone, 2153,
profiling (1.977 ms) : 1932, 2021
. : milestone, 1977,
tracing (1.947 ms) : 1905, 1990
. : milestone, 1947,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~38e651903f, baseline=1.48.0-SNAPSHOT~771fa819aa
dateFormat X
axisFormat %s
section baseline
no_agent (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
appsec (14.885 s) : 14885000, 14885000
. : milestone, 14885000,
iast (18.93 s) : 18930000, 18930000
. : milestone, 18930000,
iast_GLOBAL (17.999 s) : 17999000, 17999000
. : milestone, 17999000,
profiling (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
tracing (15.198 s) : 15198000, 15198000
. : milestone, 15198000,
section candidate
no_agent (15.544 s) : 15544000, 15544000
. : milestone, 15544000,
appsec (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
iast (18.143 s) : 18143000, 18143000
. : milestone, 18143000,
iast_GLOBAL (17.601 s) : 17601000, 17601000
. : milestone, 17601000,
profiling (15.809 s) : 15809000, 15809000
. : milestone, 15809000,
tracing (15.182 s) : 15182000, 15182000
. : milestone, 15182000,
|
ValentinZakharov
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: websocket
WebSocket Instrumentation
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8578
It looks like it will be a metric :)