-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🍒 8605 - Make TempLocationManager USER aware #8614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbachorik
approved these changes
Mar 24, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 55 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055090
Total [baseline] (8.648 s) : 0, 8647621
Agent [candidate] (1.04 s) : 0, 1040044
Total [candidate] (8.636 s) : 0, 8636086
section iast
Agent [baseline] (1.175 s) : 0, 1175016
Total [baseline] (9.251 s) : 0, 9250875
Agent [candidate] (1.182 s) : 0, 1181897
Total [candidate] (9.242 s) : 0, 9242494
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178971
Total [baseline] (9.24 s) : 0, 9240165
Agent [candidate] (1.169 s) : 0, 1169090
Total [candidate] (9.187 s) : 0, 9186943
section iast_TELEMETRY_OFF
Agent [baseline] (1.172 s) : 0, 1172431
Total [baseline] (9.224 s) : 0, 9223688
Agent [candidate] (1.167 s) : 0, 1167482
Total [candidate] (9.215 s) : 0, 9215023
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.582 ms) : 0, 723582
BytebuddyAgent [candidate] (718.313 ms) : 0, 718313
GlobalTracer [baseline] (240.996 ms) : 0, 240996
GlobalTracer [candidate] (239.679 ms) : 0, 239679
AppSec [baseline] (54.609 ms) : 0, 54609
AppSec [candidate] (55.686 ms) : 0, 55686
Remote Config [baseline] (712.532 µs) : 0, 713
Remote Config [candidate] (685.435 µs) : 0, 685
Telemetry [baseline] (14.798 ms) : 0, 14798
Telemetry [candidate] (10.658 ms) : 0, 10658
Debugger [baseline] (4.395 ms) : 0, 4395
section iast
BytebuddyAgent [baseline] (837.231 ms) : 0, 837231
BytebuddyAgent [candidate] (845.878 ms) : 0, 845878
GlobalTracer [baseline] (229.888 ms) : 0, 229888
GlobalTracer [candidate] (231.915 ms) : 0, 231915
IAST [baseline] (22.697 ms) : 0, 22697
IAST [candidate] (22.839 ms) : 0, 22839
AppSec [baseline] (55.755 ms) : 0, 55755
AppSec [candidate] (56.901 ms) : 0, 56901
Remote Config [baseline] (602.631 µs) : 0, 603
Remote Config [candidate] (606.552 µs) : 0, 607
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.679 ms) : 0, 8679
Debugger [baseline] (4.144 ms) : 0, 4144
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (839.155 ms) : 0, 839155
BytebuddyAgent [candidate] (835.103 ms) : 0, 835103
GlobalTracer [baseline] (231.33 ms) : 0, 231330
GlobalTracer [candidate] (229.724 ms) : 0, 229724
IAST [baseline] (22.935 ms) : 0, 22935
IAST [candidate] (23.145 ms) : 0, 23145
AppSec [baseline] (56.054 ms) : 0, 56054
AppSec [candidate] (56.857 ms) : 0, 56857
Remote Config [baseline] (595.301 µs) : 0, 595
Remote Config [candidate] (662.412 µs) : 0, 662
Telemetry [baseline] (8.747 ms) : 0, 8747
Telemetry [candidate] (8.694 ms) : 0, 8694
Debugger [baseline] (4.141 ms) : 0, 4141
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.982 ms) : 0, 834982
BytebuddyAgent [candidate] (833.711 ms) : 0, 833711
GlobalTracer [baseline] (230.099 ms) : 0, 230099
GlobalTracer [candidate] (230.261 ms) : 0, 230261
IAST [baseline] (22.463 ms) : 0, 22463
IAST [candidate] (22.285 ms) : 0, 22285
AppSec [baseline] (55.555 ms) : 0, 55555
AppSec [candidate] (57.121 ms) : 0, 57121
Remote Config [baseline] (606.094 µs) : 0, 606
Remote Config [candidate] (624.141 µs) : 0, 624
Telemetry [baseline] (8.607 ms) : 0, 8607
Telemetry [candidate] (8.546 ms) : 0, 8546
Debugger [baseline] (4.136 ms) : 0, 4136
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1053763
Total [baseline] (10.467 s) : 0, 10466805
Agent [candidate] (1.054 s) : 0, 1053533
Total [candidate] (10.486 s) : 0, 10486385
section appsec
Agent [baseline] (1.189 s) : 0, 1189448
Total [baseline] (10.744 s) : 0, 10744165
Agent [candidate] (1.184 s) : 0, 1184322
Total [candidate] (10.718 s) : 0, 10718460
section iast
Agent [baseline] (1.177 s) : 0, 1176611
Total [baseline] (10.998 s) : 0, 10997779
Agent [candidate] (1.171 s) : 0, 1171130
Total [candidate] (10.919 s) : 0, 10919356
section profiling
Agent [baseline] (1.268 s) : 0, 1268352
Total [baseline] (10.795 s) : 0, 10794945
Agent [candidate] (1.262 s) : 0, 1262092
Total [candidate] (10.888 s) : 0, 10887856
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.861 ms) : 0, 723861
BytebuddyAgent [candidate] (725.892 ms) : 0, 725892
GlobalTracer [baseline] (242.524 ms) : 0, 242524
GlobalTracer [candidate] (241.881 ms) : 0, 241881
AppSec [baseline] (55.785 ms) : 0, 55785
AppSec [candidate] (56.213 ms) : 0, 56213
Remote Config [baseline] (743.358 µs) : 0, 743
Remote Config [candidate] (709.853 µs) : 0, 710
Telemetry [baseline] (10.237 ms) : 0, 10237
Telemetry [candidate] (13.764 ms) : 0, 13764
Debugger [baseline] (4.498 ms) : 0, 4498
section appsec
BytebuddyAgent [baseline] (737.053 ms) : 0, 737053
BytebuddyAgent [candidate] (736.176 ms) : 0, 736176
GlobalTracer [baseline] (236.534 ms) : 0, 236534
GlobalTracer [candidate] (236.484 ms) : 0, 236484
AppSec [baseline] (174.926 ms) : 0, 174926
AppSec [candidate] (177.053 ms) : 0, 177053
Remote Config [baseline] (645.951 µs) : 0, 646
Remote Config [candidate] (658.907 µs) : 0, 659
Telemetry [baseline] (9.248 ms) : 0, 9248
Telemetry [candidate] (8.305 ms) : 0, 8305
IAST [baseline] (21.375 ms) : 0, 21375
IAST [candidate] (21.42 ms) : 0, 21420
Debugger [baseline] (4.33 ms) : 0, 4330
section iast
BytebuddyAgent [baseline] (838.248 ms) : 0, 838248
BytebuddyAgent [candidate] (837.265 ms) : 0, 837265
GlobalTracer [baseline] (230.271 ms) : 0, 230271
GlobalTracer [candidate] (230.27 ms) : 0, 230270
AppSec [baseline] (55.367 ms) : 0, 55367
AppSec [candidate] (56.62 ms) : 0, 56620
Remote Config [baseline] (587.772 µs) : 0, 588
Remote Config [candidate] (604.455 µs) : 0, 604
Telemetry [baseline] (8.667 ms) : 0, 8667
Telemetry [candidate] (8.692 ms) : 0, 8692
IAST [baseline] (23.389 ms) : 0, 23389
IAST [candidate] (22.759 ms) : 0, 22759
Debugger [baseline] (4.164 ms) : 0, 4164
section profiling
BytebuddyAgent [baseline] (707.916 ms) : 0, 707916
BytebuddyAgent [candidate] (709.298 ms) : 0, 709298
GlobalTracer [baseline] (349.55 ms) : 0, 349550
GlobalTracer [candidate] (351.621 ms) : 0, 351621
AppSec [baseline] (54.228 ms) : 0, 54228
AppSec [candidate] (54.729 ms) : 0, 54729
Remote Config [baseline] (704.651 µs) : 0, 705
Remote Config [candidate] (678.248 µs) : 0, 678
Telemetry [baseline] (8.936 ms) : 0, 8936
Telemetry [candidate] (9.121 ms) : 0, 9121
Debugger [baseline] (4.294 ms) : 0, 4294
ProfilingAgent [baseline] (101.179 ms) : 0, 101179
ProfilingAgent [candidate] (96.214 ms) : 0, 96214
Profiling [baseline] (101.354 ms) : 0, 101354
Profiling [candidate] (96.239 ms) : 0, 96239
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section baseline
no_agent (1.361 ms) : 1340, 1381
. : milestone, 1361,
appsec (1.733 ms) : 1710, 1757
. : milestone, 1733,
appsec_no_iast (1.739 ms) : 1716, 1762
. : milestone, 1739,
code_origins (1.668 ms) : 1642, 1694
. : milestone, 1668,
iast (1.535 ms) : 1511, 1559
. : milestone, 1535,
profiling (1.55 ms) : 1525, 1575
. : milestone, 1550,
tracing (1.501 ms) : 1475, 1526
. : milestone, 1501,
section candidate
no_agent (1.372 ms) : 1353, 1392
. : milestone, 1372,
appsec (1.749 ms) : 1725, 1773
. : milestone, 1749,
appsec_no_iast (1.757 ms) : 1733, 1781
. : milestone, 1757,
code_origins (1.686 ms) : 1652, 1719
. : milestone, 1686,
iast (1.512 ms) : 1488, 1536
. : milestone, 1512,
profiling (1.527 ms) : 1503, 1551
. : milestone, 1527,
tracing (1.521 ms) : 1497, 1545
. : milestone, 1521,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section baseline
no_agent (380.342 µs) : 360, 401
. : milestone, 380,
iast (521.06 µs) : 499, 543
. : milestone, 521,
iast_FULL (737.788 µs) : 716, 760
. : milestone, 738,
iast_GLOBAL (568.848 µs) : 546, 592
. : milestone, 569,
iast_HARDCODED_SECRET_DISABLED (514.263 µs) : 493, 536
. : milestone, 514,
iast_INACTIVE (462.298 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (504.707 µs) : 482, 527
. : milestone, 505,
tracing (460.137 µs) : 439, 481
. : milestone, 460,
section candidate
no_agent (381.772 µs) : 361, 402
. : milestone, 382,
iast (509.61 µs) : 488, 531
. : milestone, 510,
iast_FULL (733.517 µs) : 711, 756
. : milestone, 734,
iast_GLOBAL (563.426 µs) : 542, 585
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (512.47 µs) : 491, 534
. : milestone, 512,
iast_INACTIVE (467.497 µs) : 446, 489
. : milestone, 467,
iast_TELEMETRY_OFF (500.386 µs) : 478, 523
. : milestone, 500,
tracing (455.224 µs) : 435, 476
. : milestone, 455,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.331 ms) : 2288, 2375
. : milestone, 2331,
iast (2.113 ms) : 2058, 2169
. : milestone, 2113,
iast_GLOBAL (2.16 ms) : 2104, 2216
. : milestone, 2160,
profiling (1.984 ms) : 1939, 2029
. : milestone, 1984,
tracing (1.945 ms) : 1903, 1988
. : milestone, 1945,
section candidate
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.326 ms) : 2284, 2369
. : milestone, 2326,
iast (2.104 ms) : 2049, 2158
. : milestone, 2104,
iast_GLOBAL (2.15 ms) : 2094, 2205
. : milestone, 2150,
profiling (1.967 ms) : 1923, 2011
. : milestone, 1967,
tracing (1.93 ms) : 1888, 1972
. : milestone, 1930,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~be8fb44169, baseline=1.48.0-SNAPSHOT~fbef759198
dateFormat X
axisFormat %s
section baseline
no_agent (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
appsec (15.185 s) : 15185000, 15185000
. : milestone, 15185000,
iast (18.695 s) : 18695000, 18695000
. : milestone, 18695000,
iast_GLOBAL (18.252 s) : 18252000, 18252000
. : milestone, 18252000,
profiling (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
tracing (15.172 s) : 15172000, 15172000
. : milestone, 15172000,
section candidate
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.992 s) : 18992000, 18992000
. : milestone, 18992000,
iast_GLOBAL (18.048 s) : 18048000, 18048000
. : milestone, 18048000,
profiling (15.172 s) : 15172000, 15172000
. : milestone, 15172000,
tracing (14.739 s) : 14739000, 14739000
. : milestone, 14739000,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Mar 25, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.13.0` -> `2.13.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.2` -> `1.47.3` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.47.2` -> `1.47.3` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.6` -> `2.31.7` | --- ### Release Notes <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.13.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2131) - \[Fix]: differentiate between main and other variants when rewriting dependencies with Kotlin DSL. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.3`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.3): 1.47.3 ##### Components ##### Profiling - 🐛 🍒 8605 - Make TempLocationManager USER aware ([#​8614](DataDog/dd-trace-java#8614) - [@​mcculls](https://github.com/mcculls)) ##### Instrumentations ##### All other instrumentations - ✨ 🍒 8601 - Introduce cache for peer.hostname lookup ([#​8611](DataDog/dd-trace-java#8611) - [@​mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 270c10cb444c28cb64015d9874ef52d6a175c271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8605 to release/v1.47.x