Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate context injection calls to context-first APIs #8358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate context injection calls to context-first APIs #8358

wants to merge 4 commits into from
+352 −97

Conversation

PerfectSlayer
Copy link
Contributor

What Does This Do

This PR migrates the AgentPropagation API call to the new context tracking API for context injection.

Motivation

Migrate to context-first API and deprecate / remove the AgentPropagation.

Additional Notes

Context extraction will be migrated in a following PR.
Simplification of carrier visitor / getter / setter will come in another PR.
Some injection calls will be simplified in a later PR with DSM propagator introduction.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@PerfectSlayer PerfectSlayer requested review from a team as code owners February 7, 2025 16:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@PerfectSlayer PerfectSlayer changed the title Bbujon/context propagation step4 Migrate context injection call to context-first APIs Feb 7, 2025
@PerfectSlayer PerfectSlayer changed the title Migrate context injection call to context-first APIs Migrate context injection calls to context-first APIs Feb 7, 2025
@PerfectSlayer PerfectSlayer requested a review from mcculls February 7, 2025 16:57
@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025 •
edited
Loading

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-step4
git_commit_date 1738946056 1738946623
git_commit_sha 3f4b7a8 3f9d322
See matching parameters
Baseline Candidate
ci_job_date 1738950963 1738950963
ci_job_id 799480779 799480779
ci_pipeline_id 55277963 55277963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce unsure
[-5594.533op/s; -1036.902op/s] or [-4.114%; -0.763%]

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-step4
git_commit_date 1738946056 1738946623
git_commit_sha 3f4b7a8 3f9d322
release_version 1.47.0-SNAPSHOT~3f4b7a8a2b 1.47.0-SNAPSHOT~3f9d322981
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738952341 1738952341
ci_job_id 799480775 799480775
ci_pipeline_id 55277963 55277963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-rxqfpxvm-project-304-concurrent-0-nowr162m 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-rxqfpxvm-project-304-concurrent-0-nowr162m 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042574
Total [baseline] (10.481 s) : 0, 10481387
Agent [candidate] (1.054 s) : 0, 1054038
Total [candidate] (10.545 s) : 0, 10544760
section appsec
Agent [baseline] (1.188 s) : 0, 1188030
Total [baseline] (10.709 s) : 0, 10709154
Agent [candidate] (1.184 s) : 0, 1183564
Total [candidate] (10.715 s) : 0, 10715155
section iast
Agent [baseline] (1.172 s) : 0, 1172017
Total [baseline] (10.997 s) : 0, 10996698
Agent [candidate] (1.179 s) : 0, 1178713
Total [candidate] (11.003 s) : 0, 11002906
section profiling
Agent [baseline] (1.273 s) : 0, 1273072
Total [baseline] (10.847 s) : 0, 10846746
Agent [candidate] (1.261 s) : 0, 1261459
Total [candidate] (10.857 s) : 0, 10856515
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.043 s -
Agent appsec 1.188 s 145.456 ms (14.0%)
Agent iast 1.172 s 129.443 ms (12.4%)
Agent profiling 1.273 s 230.498 ms (22.1%)
Total tracing 10.481 s -
Total appsec 10.709 s 227.767 ms (2.2%)
Total iast 10.997 s 515.311 ms (4.9%)
Total profiling 10.847 s 365.359 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent appsec 1.184 s 129.527 ms (12.3%)
Agent iast 1.179 s 124.675 ms (11.8%)
Agent profiling 1.261 s 207.422 ms (19.7%)
Total tracing 10.545 s -
Total appsec 10.715 s 170.394 ms (1.6%)
Total iast 11.003 s 458.145 ms (4.3%)
Total profiling 10.857 s 311.754 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.425 ms) : 0, 715425
BytebuddyAgent [candidate] (722.54 ms) : 0, 722540
GlobalTracer [baseline] (242.913 ms) : 0, 242913
GlobalTracer [candidate] (246.298 ms) : 0, 246298
AppSec [baseline] (55.273 ms) : 0, 55273
AppSec [candidate] (55.978 ms) : 0, 55978
Remote Config [baseline] (732.594 µs) : 0, 733
Remote Config [candidate] (740.704 µs) : 0, 741
Telemetry [baseline] (12.994 ms) : 0, 12994
Telemetry [candidate] (13.138 ms) : 0, 13138
section appsec
BytebuddyAgent [baseline] (735.949 ms) : 0, 735949
BytebuddyAgent [candidate] (732.637 ms) : 0, 732637
GlobalTracer [baseline] (240.618 ms) : 0, 240618
GlobalTracer [candidate] (240.081 ms) : 0, 240081
AppSec [baseline] (176.35 ms) : 0, 176350
AppSec [candidate] (175.554 ms) : 0, 175554
Remote Config [baseline] (659.468 µs) : 0, 659
Remote Config [candidate] (653.94 µs) : 0, 654
Telemetry [baseline] (8.288 ms) : 0, 8288
Telemetry [candidate] (8.623 ms) : 0, 8623
IAST [baseline] (21.819 ms) : 0, 21819
IAST [candidate] (21.691 ms) : 0, 21691
section iast
BytebuddyAgent [baseline] (834.452 ms) : 0, 834452
BytebuddyAgent [candidate] (839.92 ms) : 0, 839920
GlobalTracer [baseline] (233.511 ms) : 0, 233511
GlobalTracer [candidate] (233.892 ms) : 0, 233892
AppSec [baseline] (56.7 ms) : 0, 56700
AppSec [candidate] (57.317 ms) : 0, 57317
Remote Config [baseline] (613.98 µs) : 0, 614
Remote Config [candidate] (622.727 µs) : 0, 623
Telemetry [baseline] (8.671 ms) : 0, 8671
Telemetry [candidate] (8.729 ms) : 0, 8729
IAST [baseline] (22.86 ms) : 0, 22860
IAST [candidate] (22.812 ms) : 0, 22812
section profiling
ProfilingAgent [baseline] (97.012 ms) : 0, 97012
ProfilingAgent [candidate] (95.349 ms) : 0, 95349
BytebuddyAgent [baseline] (711.972 ms) : 0, 711972
BytebuddyAgent [candidate] (705.882 ms) : 0, 705882
GlobalTracer [baseline] (355.878 ms) : 0, 355878
GlobalTracer [candidate] (353.784 ms) : 0, 353784
AppSec [baseline] (55.851 ms) : 0, 55851
AppSec [candidate] (54.557 ms) : 0, 54557
Remote Config [baseline] (719.531 µs) : 0, 720
Remote Config [candidate] (705.063 µs) : 0, 705
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (8.893 ms) : 0, 8893
Profiling [baseline] (97.038 ms) : 0, 97038
Profiling [candidate] (95.373 ms) : 0, 95373
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043858
Total [baseline] (8.667 s) : 0, 8667498
Agent [candidate] (1.048 s) : 0, 1047984
Total [candidate] (8.643 s) : 0, 8643155
section iast
Agent [baseline] (1.184 s) : 0, 1183810
Total [baseline] (9.26 s) : 0, 9260329
Agent [candidate] (1.172 s) : 0, 1171657
Total [candidate] (9.211 s) : 0, 9211009
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174173
Total [baseline] (9.188 s) : 0, 9188392
Agent [candidate] (1.181 s) : 0, 1180592
Total [candidate] (9.229 s) : 0, 9228510
section iast_TELEMETRY_OFF
Agent [baseline] (1.187 s) : 0, 1186521
Total [baseline] (9.239 s) : 0, 9238581
Agent [candidate] (1.166 s) : 0, 1166252
Total [candidate] (9.235 s) : 0, 9235248
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent iast 1.184 s 139.952 ms (13.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 130.315 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.187 s 142.663 ms (13.7%)
Total tracing 8.667 s -
Total iast 9.26 s 592.83 ms (6.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.188 s 520.894 ms (6.0%)
Total iast_TELEMETRY_OFF 9.239 s 571.083 ms (6.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.172 s 123.673 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 132.607 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.166 s 118.268 ms (11.3%)
Total tracing 8.643 s -
Total iast 9.211 s 567.854 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.229 s 585.355 ms (6.8%)
Total iast_TELEMETRY_OFF 9.235 s 592.094 ms (6.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.275 ms) : 0, 717275
BytebuddyAgent [candidate] (720.171 ms) : 0, 720171
GlobalTracer [baseline] (243.763 ms) : 0, 243763
GlobalTracer [candidate] (244.579 ms) : 0, 244579
AppSec [baseline] (55.255 ms) : 0, 55255
AppSec [candidate] (55.555 ms) : 0, 55555
Remote Config [baseline] (718.279 µs) : 0, 718
Remote Config [candidate] (730.631 µs) : 0, 731
Telemetry [baseline] (11.532 ms) : 0, 11532
Telemetry [candidate] (11.645 ms) : 0, 11645
section iast
BytebuddyAgent [baseline] (842.772 ms) : 0, 842772
BytebuddyAgent [candidate] (834.121 ms) : 0, 834121
GlobalTracer [baseline] (235.61 ms) : 0, 235610
GlobalTracer [candidate] (233.248 ms) : 0, 233248
IAST [baseline] (23.253 ms) : 0, 23253
IAST [candidate] (22.782 ms) : 0, 22782
AppSec [baseline] (57.289 ms) : 0, 57289
AppSec [candidate] (57.002 ms) : 0, 57002
Remote Config [baseline] (621.221 µs) : 0, 621
Remote Config [candidate] (625.962 µs) : 0, 626
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.712 ms) : 0, 8712
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.7 ms) : 0, 835700
BytebuddyAgent [candidate] (841.347 ms) : 0, 841347
GlobalTracer [baseline] (233.68 ms) : 0, 233680
GlobalTracer [candidate] (234.533 ms) : 0, 234533
IAST [baseline] (22.737 ms) : 0, 22737
IAST [candidate] (22.919 ms) : 0, 22919
AppSec [baseline] (57.358 ms) : 0, 57358
AppSec [candidate] (57.012 ms) : 0, 57012
Remote Config [baseline] (633.696 µs) : 0, 634
Remote Config [candidate] (620.761 µs) : 0, 621
Telemetry [baseline] (8.748 ms) : 0, 8748
Telemetry [candidate] (8.795 ms) : 0, 8795
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (845.109 ms) : 0, 845109
BytebuddyAgent [candidate] (829.674 ms) : 0, 829674
GlobalTracer [baseline] (236.367 ms) : 0, 236367
GlobalTracer [candidate] (233.418 ms) : 0, 233418
IAST [baseline] (24.992 ms) : 0, 24992
IAST [candidate] (26.863 ms) : 0, 26863
AppSec [baseline] (55.024 ms) : 0, 55024
AppSec [candidate] (51.796 ms) : 0, 51796
Remote Config [baseline] (630.292 µs) : 0, 630
Remote Config [candidate] (607.876 µs) : 0, 608
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.594 ms) : 0, 8594
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-07T17:51:01 2025-02-07T17:58:03
git_branch master bbujon/context-propagation-step4
git_commit_date 1738946056 1738946623
git_commit_sha 3f4b7a8 3f9d322
release_version 1.47.0-SNAPSHOT~3f4b7a8a2b 1.47.0-SNAPSHOT~3f9d322981
start_time 2025-02-07T17:50:47 2025-02-07T17:57:49
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738951441 1738951441
ci_job_id 799480776 799480776
ci_pipeline_id 55277963 55277963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-shpxzk8g-project-304-concurrent-1-pgb8dxu5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-shpxzk8g-project-304-concurrent-1-pgb8dxu5 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1358
.   : milestone, 1338,
appsec (1.75 ms) : 1727, 1773
.   : milestone, 1750,
appsec_no_iast (1.748 ms) : 1725, 1771
.   : milestone, 1748,
iast (1.5 ms) : 1475, 1525
.   : milestone, 1500,
profiling (1.522 ms) : 1497, 1547
.   : milestone, 1522,
tracing (1.498 ms) : 1475, 1522
.   : milestone, 1498,
section candidate
no_agent (1.363 ms) : 1343, 1383
.   : milestone, 1363,
appsec (1.738 ms) : 1714, 1761
.   : milestone, 1738,
appsec_no_iast (1.751 ms) : 1726, 1776
.   : milestone, 1751,
iast (1.521 ms) : 1498, 1545
.   : milestone, 1521,
profiling (1.495 ms) : 1471, 1519
.   : milestone, 1495,
tracing (1.489 ms) : 1463, 1514
.   : milestone, 1489,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.358 ms] -
appsec 1.75 ms [1.727 ms, 1.773 ms] 412.162 µs (30.8%)
appsec_no_iast 1.748 ms [1.725 ms, 1.771 ms] 410.141 µs (30.6%)
iast 1.5 ms [1.475 ms, 1.525 ms] 161.988 µs (12.1%)
profiling 1.522 ms [1.497 ms, 1.547 ms] 183.983 µs (13.7%)
tracing 1.498 ms [1.475 ms, 1.522 ms] 160.125 µs (12.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.343 ms, 1.383 ms] -
appsec 1.738 ms [1.714 ms, 1.761 ms] 374.811 µs (27.5%)
appsec_no_iast 1.751 ms [1.726 ms, 1.776 ms] 387.992 µs (28.5%)
iast 1.521 ms [1.498 ms, 1.545 ms] 158.465 µs (11.6%)
profiling 1.495 ms [1.471 ms, 1.519 ms] 132.402 µs (9.7%)
tracing 1.489 ms [1.463 ms, 1.514 ms] 125.972 µs (9.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (380.319 µs) : 357, 403
.   : milestone, 380,
iast (506.973 µs) : 486, 528
.   : milestone, 507,
iast_FULL (732.344 µs) : 711, 754
.   : milestone, 732,
iast_GLOBAL (554.891 µs) : 533, 577
.   : milestone, 555,
iast_HARDCODED_SECRET_DISABLED (502.84 µs) : 481, 525
.   : milestone, 503,
iast_INACTIVE (454.29 µs) : 433, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (500.881 µs) : 478, 524
.   : milestone, 501,
tracing (453.907 µs) : 433, 475
.   : milestone, 454,
section candidate
no_agent (372.86 µs) : 353, 392
.   : milestone, 373,
iast (506.435 µs) : 484, 528
.   : milestone, 506,
iast_FULL (739.08 µs) : 717, 761
.   : milestone, 739,
iast_GLOBAL (559.305 µs) : 537, 581
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (508.046 µs) : 487, 530
.   : milestone, 508,
iast_INACTIVE (464.119 µs) : 443, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (512.776 µs) : 490, 536
.   : milestone, 513,
tracing (445.874 µs) : 425, 466
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.319 µs [357.449 µs, 403.189 µs] -
iast 506.973 µs [485.54 µs, 528.406 µs] 126.654 µs (33.3%)
iast_FULL 732.344 µs [710.506 µs, 754.183 µs] 352.025 µs (92.6%)
iast_GLOBAL 554.891 µs [532.846 µs, 576.936 µs] 174.572 µs (45.9%)
iast_HARDCODED_SECRET_DISABLED 502.84 µs [481.165 µs, 524.515 µs] 122.521 µs (32.2%)
iast_INACTIVE 454.29 µs [433.014 µs, 475.565 µs] 73.971 µs (19.4%)
iast_TELEMETRY_OFF 500.881 µs [477.684 µs, 524.078 µs] 120.562 µs (31.7%)
tracing 453.907 µs [432.708 µs, 475.106 µs] 73.588 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.86 µs [353.391 µs, 392.33 µs] -
iast 506.435 µs [484.451 µs, 528.418 µs] 133.574 µs (35.8%)
iast_FULL 739.08 µs [717.252 µs, 760.907 µs] 366.219 µs (98.2%)
iast_GLOBAL 559.305 µs [537.222 µs, 581.388 µs] 186.445 µs (50.0%)
iast_HARDCODED_SECRET_DISABLED 508.046 µs [486.535 µs, 529.557 µs] 135.186 µs (36.3%)
iast_INACTIVE 464.119 µs [442.644 µs, 485.594 µs] 91.259 µs (24.5%)
iast_TELEMETRY_OFF 512.776 µs [489.612 µs, 535.941 µs] 139.916 µs (37.5%)
tracing 445.874 µs [425.452 µs, 466.296 µs] 73.014 µs (19.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-step4
git_commit_date 1738946056 1738946623
git_commit_sha 3f4b7a8 3f9d322
release_version 1.47.0-SNAPSHOT~3f4b7a8a2b 1.47.0-SNAPSHOT~3f9d322981
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738951923 1738951923
ci_job_id 799480777 799480777
ci_pipeline_id 55277963 55277963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ahguadnm-project-304-concurrent-1-d3ox0sww 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ahguadnm-project-304-concurrent-1-d3ox0sww 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.379 ms) : 2335, 2422
.   : milestone, 2379,
iast (2.116 ms) : 2061, 2171
.   : milestone, 2116,
iast_GLOBAL (2.168 ms) : 2113, 2223
.   : milestone, 2168,
profiling (1.981 ms) : 1936, 2025
.   : milestone, 1981,
tracing (1.959 ms) : 1917, 2001
.   : milestone, 1959,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.39 ms) : 2347, 2434
.   : milestone, 2390,
iast (2.115 ms) : 2060, 2170
.   : milestone, 2115,
iast_GLOBAL (2.16 ms) : 2105, 2215
.   : milestone, 2160,
profiling (1.971 ms) : 1927, 2014
.   : milestone, 1971,
tracing (1.958 ms) : 1915, 2000
.   : milestone, 1958,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.379 ms [2.335 ms, 2.422 ms] 902.715 µs (61.2%)
iast 2.116 ms [2.061 ms, 2.171 ms] 639.878 µs (43.3%)
iast_GLOBAL 2.168 ms [2.113 ms, 2.223 ms] 691.886 µs (46.9%)
profiling 1.981 ms [1.936 ms, 2.025 ms] 504.429 µs (34.2%)
tracing 1.959 ms [1.917 ms, 2.001 ms] 482.574 µs (32.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.39 ms [2.347 ms, 2.434 ms] 912.442 µs (61.7%)
iast 2.115 ms [2.06 ms, 2.17 ms] 636.889 µs (43.1%)
iast_GLOBAL 2.16 ms [2.105 ms, 2.215 ms] 681.871 µs (46.1%)
profiling 1.971 ms [1.927 ms, 2.014 ms] 492.456 µs (33.3%)
tracing 1.958 ms [1.915 ms, 2.0 ms] 479.812 µs (32.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~3f9d322981, baseline=1.47.0-SNAPSHOT~3f4b7a8a2b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.026 s) : 15026000, 15026000
.   : milestone, 15026000,
appsec (15.833 s) : 15833000, 15833000
.   : milestone, 15833000,
iast (18.389 s) : 18389000, 18389000
.   : milestone, 18389000,
iast_GLOBAL (18.259 s) : 18259000, 18259000
.   : milestone, 18259000,
profiling (15.188 s) : 15188000, 15188000
.   : milestone, 15188000,
tracing (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
section candidate
no_agent (15.503 s) : 15503000, 15503000
.   : milestone, 15503000,
appsec (15.007 s) : 15007000, 15007000
.   : milestone, 15007000,
iast (18.228 s) : 18228000, 18228000
.   : milestone, 18228000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
.   : milestone, 17985000,
profiling (14.995 s) : 14995000, 14995000
.   : milestone, 14995000,
tracing (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.026 s [15.026 s, 15.026 s] -
appsec 15.833 s [15.833 s, 15.833 s] 807.0 ms (5.4%)
iast 18.389 s [18.389 s, 18.389 s] 3.363 s (22.4%)
iast_GLOBAL 18.259 s [18.259 s, 18.259 s] 3.233 s (21.5%)
profiling 15.188 s [15.188 s, 15.188 s] 162.0 ms (1.1%)
tracing 14.951 s [14.951 s, 14.951 s] -75.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.503 s [15.503 s, 15.503 s] -
appsec 15.007 s [15.007 s, 15.007 s] -496.0 ms (-3.2%)
iast 18.228 s [18.228 s, 18.228 s] 2.725 s (17.6%)
iast_GLOBAL 17.985 s [17.985 s, 17.985 s] 2.482 s (16.0%)
profiling 14.995 s [14.995 s, 14.995 s] -508.0 ms (-3.3%)
tracing 15.149 s [15.149 s, 15.149 s] -354.0 ms (-2.3%)

@PerfectSlayer
Copy link
Contributor Author

Smoke tests seems to be complaining about standalaone ASM. I will include this refactoring as well.

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2025 •
edited
Loading

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/context-propagation-step4
git_commit_date 1738946056 1738946623
git_commit_sha 3f4b7a8 3f9d322
See matching parameters
Baseline Candidate
ci_job_date 1738951124 1738951124
ci_job_id 799480780 799480780
ci_pipeline_id 55277963 55277963
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog Awaiting requested review from nikita-tkachenko-datadog nikita-tkachenko-datadog is a code owner automatically assigned from DataDog/ci-app-libraries-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

@mcculls mcculls Awaiting requested review from mcculls

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: core Tracer core type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PerfectSlayer