Add on-call schedules endpoint #584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
2 times, most recently
from
82e04ce to
72e354a
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
from
72e354a to
cda6a1f
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
from
cda6a1f to
376efbb
Compare
| @@ -295,6 +295,7 @@ def operation_specs(specs): | |||
| def api(context, api_version, specs, name): | |||
| """Return an API instance.""" | |||
| assert name in {tag["name"].replace(" ", "") for tag in specs[api_version]["tags"]} | |||
| name = name.replace("-", "") | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
variable name is the same as a function parameter (...read more)
A function parameter should only be read and not be modified. If your intent is to modify the value of the parameter, return the value in the function and handle the new value in the caller of the function.
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
from
376efbb to
0b59ee9
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
3 times, most recently
from
956ffd2 to
dc2aade
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/3653
branch
from
dc2aade to
5383314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#3653
Test branch datadog-api-spec/test/d.marin/oncall-api