-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix progress bar still capturing stderr after exception #16
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
===========================================
+ Coverage 99.54% 99.54% +<.01%
===========================================
Files 9 9
Lines 439 442 +3
===========================================
+ Hits 437 440 +3
Misses 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember this issue, so using a context manager should solve the problem.
Didn't test it, but it makes sense.
I would like to open an issue on the progress bar repository. |
Looks like a similar issue was submitted, and that the progress bar can be already used as a context manager to prevent the problem. So this PR is redundant, but not the final use of the different progress bars. I will check that and adapt the code. |
No need to create a context manager in the module, as the bar has one already.
I adapted the code, it is better to used the already provided secure mechanism. |
Fixes #15, fixes #22.