Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disentangled mechanism to obtain mlflow model #578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disentangled mechanism to obtain mlflow model #578

wants to merge 2 commits into from

Conversation

jinensetpal
Copy link
Collaborator

https://github.com/DagsHub/ls-configurable-model/ also loads mlflow models from dagshub repos, same as {predict,annotate}_with_mlflow, code is duplicated and changes need to be propagated. This disentaglement helps with code re-use.

@jinensetpal jinensetpal requested a review from kbolashev January 8, 2025 01:51
@dagshub DagsHub
Copy link

dagshub bot commented Jan 8, 2025

Join the discussion on DagsHub!

@jinensetpal jinensetpal self-assigned this Jan 8, 2025
@jinensetpal jinensetpal mentioned this pull request Jan 8, 2025
Merged
kbolashev
kbolashev approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, I think it could be a useful public-facing function!

dagshub/mlflow/get_model.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbolashev kbolashev kbolashev approved these changes

Assignees

@jinensetpal jinensetpal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinensetpal @kbolashev