Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add more CrossmintAuth tests, add isEmailValid tests #989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wsdt
Copy link

@wsdt wsdt commented Mar 20, 2025

Changelog

[X] No dependencies added
[X] No changes to code or existing tests

Unit tests

  • Added more unit tests to packages/common/auth/CrossmintAuth.test.ts
  • Added isEmailValid tests in packages/common/auth/utils/isEmailValid.test.ts
  • No changes to existing tests

Would love some feedback on this!

Personally have used CrossMint on couple of projects and love what you do.

Hope you find this helpful!

--

Subtle sale (sorry for the shameless promotion):
We help with your QA while you can focus on what you do best - pushing forward your roadmap.

test

Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: fcab386

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
crossmint-sdk-remix-ssr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 1:50pm

Copy link

vercel bot commented Mar 20, 2025

@wsdt is attempting to deploy a commit to the Crossmint Team on Vercel.

A member of the Team first needs to authorize it.

@wsdt
Copy link
Author

wsdt commented Mar 23, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant