Prevent damage to Extendo-Grip from Frost Walker #7339
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frost Walker places frosted ice blocks through the EntityPlaceEvent. Currently, the event then damages the Extendo-Grip for every frosted ice block placed by the enchantment, rapidly breaking it. This fix prevents damage to the Extendo-Grip when the block is Frosted Ice and the player's equipment has Frost Walker.
|
This should fix #5494. |
VoidLeech
reviewed
Feb 6, 2025
There was a problem hiding this comment.
You should have the call to findAndDamageExtendoGrip not be in an else block, and just do an early return. As is, this is going to call findAndDamageExtendoGrip if any armor piece has any enchantment that isn’t Frost Walker, and multiple times as well.
Also, there should just be a method in EnchantmentHelper that’ll tell you whether an entity has an enchantment, no need to iterate over armorslots and enchantments. (And if iterating over armorslots was necessary, there’s always Map#containsKey)
Checking to see if the block is Frosted Ice is failing, possibly due to the event happening before the block is placed.
|
this will deal no damage when the player is placing blocks in water. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frost Walker places frosted ice blocks through the EntityPlaceEvent. Currently, the event then damages the Extendo-Grip for every frosted ice block placed by the enchantment, rapidly breaking it. This fix prevents damage to the Extendo-Grip when the block is Frosted Ice and the player's equipment has Frost Walker.