Add new entrypoint for IBCv2 Timeout #2435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CosmWasm#2422 Add new entry point for IBCv2 Timeout in `contracts/ibc2/src/contract.rs`. * **State Struct** - Add `ibc2_timeout_counter` field to `State` struct. * **QueryMsg Enum** - Add `QueryTimeoutCounter` message to retrieve the timeout counter. * **Query Function** - Update `query` function to handle `QueryTimeoutCounter` message. * **ibc2_timeout Function** - Add `ibc2_timeout` entry point function to handle IBCv2 timeouts. - Increment `ibc2_timeout_counter` in `State` struct within `ibc2_timeout`. * **Tests** - Add test for `ibc2_timeout` entry point function. - Verify `ibc2_timeout_counter` increments correctly. - Add test for `QueryTimeoutCounter` message. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/CosmWasm/cosmwasm/issues/2422?shareId=XXXX-XXXX-XXXX-XXXX).
* Verify `ibc2_timeout_counter` increments correctly * Add test for `QueryTimeoutCounter` message
* Add `do_ibc2_timeout` to imports in `contracts/ibc2/src/contract.rs` * Add `Empty` to imports in `contracts/ibc2/tests/integration.rs`
* Increment `ibc2_timeout_counter` in `State` struct within `ibc2_timeout` * Update `State` struct to include `ibc2_timeout_counter` field * Add `QueryTimeoutCounter` message to retrieve the timeout counter * Update `query` function to handle `QueryTimeoutCounter` message * Import `do_ibc2_timeout` function from `cosmwasm_std`
* Add `ibc2_timeout` entry point function to handle IBCv2 timeouts in `contracts/ibc2/src/contract.rs` * Add tests for `ibc2_timeout` entry point in `contracts/ibc2/tests/integration.rs` - Verify `ibc2_timeout_counter` increments correctly * Add `QueryTimeoutCounter` message to retrieve timeout counter in `contracts/ibc2/schema/raw/query.json`
…ct.rs` * Add `ibc2_timeout` entry point function to handle IBCv2 timeouts * Update imports to include necessary dependencies for `ibc2_timeout` function
* Import `do_ibc2_timeout` function from `cosmwasm_std` to handle IBCv2 timeouts
* Replace `do_ibc2_timeout` with `ibc2_timeout` in the import list * Update import list to include `ibc2_timeout` instead of `do_ibc2_timeout`
* Add `ibc2_timeout` entry point function to handle IBCv2 timeouts * Increment `ibc2_timeout_counter` in the `State` struct * Update `State` struct to include `ibc2_timeout_counter` * Fix error in `from_json` function call * Update import statements to include necessary dependencies
chipshort
reviewed
Mar 24, 2025
| pub fn ibc2_timeout( | ||
| deps: DepsMut, | ||
| _env: Env, | ||
| _msg: Ibc2PacketReceiveMsg, |
There was a problem hiding this comment.
This needs its own type.
Comment on lines
+20
to
+21
| #[returns(u32)] | ||
| QueryTimeoutCounter {}, |
There was a problem hiding this comment.
There isn't really a need for this query, since the QueryState already contains the timeout counter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2422
Add new entry point for IBCv2 Timeout in
contracts/ibc2/src/contract.rs.ibc2_timeout_counterfield toStatestruct.QueryTimeoutCountermessage to retrieve the timeout counter.queryfunction to handleQueryTimeoutCountermessage.ibc2_timeoutentry point function to handle IBCv2 timeouts.ibc2_timeout_counterinStatestruct withinibc2_timeout.ibc2_timeoutentry point function.ibc2_timeout_counterincrements correctly.QueryTimeoutCountermessage.For more details, open the Copilot Workspace session.