Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 2 #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue 2 #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c129095
Adding parameter for filtering labels, resolve #2
hutchgrant Nov 18, 2018
7d34ade
Adding mock test for labelFilter
hutchgrant Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ if (!isProduction) {
const mockEvent = {
queryStringParameters: {
projectName: 'contributarycommunity',
repoName: 'www.contributary.community'
repoName: 'www.contributary.community',
labelFilter: 'good+first+issue'
}
};

Expand All @@ -37,7 +38,7 @@ function writeToFilesystem(response) {
if (err) {
return console.error(err); // eslint-disable-line no-console
}

console.log(`File ${filePath} was saved!`); // eslint-disable-line no-console
});
}
Expand All @@ -61,11 +62,12 @@ function handleIssuesResponse(response) {

// https://developer.github.com/v3/issues/
// application/vnd.github.symmetra-preview+json
function getIssues(projectName, repositoryName) {
function getIssues(projectName, repositoryName, labelFilter) {
const midFix = `${projectName}/${repositoryName}`;
const labelFix = labelFilter ? `?labels=${labelFilter}` : '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

midFix was just something I used since the URL segment was neither at the beginning or the end.

For something like query parameters, I would probably consider calling it something like labelsQueryParams. If we add additional query parameters, likely we'll want to keep the addition of the ? part programmatic and not specific to the actual key / value string.

const options = {
host,
path: `/repos/${midFix}/issues`,
path: `/repos/${midFix}/issues${labelFix}`,
headers
};

Expand All @@ -91,9 +93,9 @@ function getIssues(projectName, repositoryName) {
}

function run(event = {}) {
const { projectName, repoName } = event.queryStringParameters;
const { projectName, repoName, labelFilter } = event.queryStringParameters;

return getIssues(projectName, repoName)
return getIssues(projectName, repoName, labelFilter)
.then(handleIssuesResponse)
.catch((error) => {
console.error(error); // eslint-disable-line no-console
Expand Down