Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AND-115 Fix CIS-2 notifications not working if CCD notifications are disabled #211

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@

- Crash on launch when Google Play Services is disabled
- Inconsistent transaction fee for invoke smart contract
- Crashing when first launching the app offline
- Crashing when first launching the app offline
- Not receiving CIS-2 transaction notifications when they are disabled for CCD transactions

### Changed

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class TransactionNotificationsManager(
get() = areNotificationsEnabled && notificationsPreferences.areCcdTxNotificationsEnabled

private val areCis2TxNotificationsEnabled: Boolean
get() = areNotificationsEnabled && notificationsPreferences.areCcdTxNotificationsEnabled
get() = areNotificationsEnabled && notificationsPreferences.areCis2TxNotificationsEnabled

@SuppressLint("MissingPermission")
fun notifyCcdTransaction(
Expand Down