Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AND-118 Fix crash when first launching the app and creating a wallet offline #204

Merged
merged 1 commit into from
Nov 25, 2024
Merged

AND-118 Fix crash when first launching the app and creating a wallet offline #204

merged 1 commit into from
Nov 25, 2024

Conversation

Radiokot
Copy link
Member

Purpose

Fix crash when first launching the app and creating a wallet offline

Changes

  • Expect getting the Firebase token to fail
  • Trying to update the subscription without the token is no longer considered successful

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@Radiokot
Expect getting firebase token to fail
07409d0 
When called for the first time and there is no internet connection,
the token is not returned.
@Radiokot Radiokot requested a review from zaiatsartem November 25, 2024 10:55
@Radiokot Radiokot merged commit 8a4db20 into main Nov 25, 2024
3 checks passed
@Radiokot Radiokot deleted the fix/AND-118-crash-when-first-launching-offline branch November 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaiatsartem zaiatsartem zaiatsartem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Radiokot @zaiatsartem