Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/AND-113 update Swipelux onramp flow #197

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Feature/AND-113 update Swipelux onramp flow #197

merged 4 commits into from
Nov 21, 2024

Conversation

zaiatsartem
Copy link
Contributor

Purpose

Update Swipelux onramp flow

Changes

Use the new customizable page allowing pre-setting the address and the token for the Swipelux payment gateway

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@zaiatsartem
Update the Swipelux onramp flow
8a77019 
Use the new customizable page allowing pre-setting the address and the token
@zaiatsartem
Merge branch 'main' into feature/AND-113_update_swipelux_onramp_flow
38edfba
@zaiatsartem zaiatsartem requested a review from Radiokot November 21, 2024 09:05
Radiokot
Radiokot requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move the specific Swipelux logic inside OpenCcdOnrampSiteWithAccountUseCase
Then it will not be duplicated on two screens

@zaiatsartem zaiatsartem merged commit f480a04 into main Nov 21, 2024
3 checks passed
@Radiokot Radiokot deleted the feature/AND-113_update_swipelux_onramp_flow branch November 22, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radiokot Radiokot Radiokot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaiatsartem @Radiokot