Delay handler execution till after state update #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the state update has been written.
| update ([#1352](https://github.com/Concordium/concordium-node/issues/1352)). The fix delays | ||
| executing the on-block and on-finalization handlers until after the state update has been | ||
| committed. This also should also result in better consistency in the gRPC API (i.e. if a client | ||
| is notified that a block has arrived, `GetBlockInfo` should not result in `NOT_FOUND` for thatb |
There was a problem hiding this comment.
Suggested change
| is notified that a block has arrived, `GetBlockInfo` should not result in `NOT_FOUND` for thatb | |
| is notified that a block has arrived, `GetBlockInfo` should not result in `NOT_FOUND` for that |
drsk0
approved these changes
Mar 24, 2025
| - Fix a bug that can occasionally result in a crash if `GetBlockInfo` is invoked during a protocol | ||
| update ([#1352](https://github.com/Concordium/concordium-node/issues/1352)). The fix delays | ||
| executing the on-block and on-finalization handlers until after the state update has been | ||
| committed. This also should also result in better consistency in the gRPC API (i.e. if a client |
There was a problem hiding this comment.
typo: "This also should also ... "
| bufferedSendCatchUpStatus | ||
| forM_ finalizedBlocks $ \bp -> do | ||
| let height = localToAbsoluteBlockHeight genHeight (SkovV1.blockHeight bp) | ||
| let isHomeBaked = case nodeBakerIdMaybe of |
There was a problem hiding this comment.
could we factor this out and reuse in skovV1BlockHandler
eb-concordium
approved these changes
Mar 24, 2025
|
@td202 are there tests for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #1352
This defers the execution of on-block and on-finalization handlers until after the consensus state has been committed. This in particular ensures that in the case of a protocol update, the consensus state is committed before the protocol update occurs (as this is part of the on-finalization handling). Consequently, a
GetBlockInfothat queries the genesis block of a new consensus (created in the protocol update) will always be able to see the terminal block (which is available once the consensus state is committed).This also ensures that if gRPC clients are notified of block arrivals, queries about those blocks will not fail, which was previously a theoretical possibility.
Changes
SkovTimplementation uses theMonadWriteraspect to produce a sequence ofHandlerEvents rather than directly invoking a handler callback.onBlockHandler,onFinalizationHandlerandonPendingLiveHandlerare removed from theHandlerContext, as the events will be used instead. (onPendingLiveHandlerwas not used anyway.)HandlerContextimplementation to separate functionsskovV1BlockHandlerandskovV1FinalizeHandler.liftSkovV1Update, and are run after updating the state.Checklist
hard-to-understand areas.